Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: port SD to full react-based instrument #7345

Merged
merged 18 commits into from
Jan 10, 2023

Conversation

Saschl
Copy link
Contributor

@Saschl Saschl commented Jul 17, 2022

Fixes #[issue_no]

Summary of Changes

  • point panel.cfg entry to template.html
  • port permanent data area
  • port logic (auto switching etc.)
    -[ ] ensure accuracy (font sizes, layout...) (later, when systems are in place)

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Logic of the screens have not been touched by this PR so we don't expect any visual changes. However, here some points that can be checked.

  1. Make sure all pages are selectable and show correct/meaningful data.
  2. Test ECAM ALL button (pages should cycle in a one second interval)
  3. Verify auto switching behaviour when no page is selected (non exhaustive list following)
    • Deselect any active ecam page when C&D and turn on the API -> APU page should appear
    • Start the engines -> ENG page should show up
    • While taxiing, move any control surface fully and verify the F/CTL page is showing up. When releasing controls, page should switch back after 20s
  • In cruise, CRZ page should be shown
  1. General observation of any possible weird behaviour.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@Benjozork
Copy link
Member

SD on my phone, here we come

@Benjozork Benjozork force-pushed the refactor/sd-full-react branch from f57a3da to b4af1c4 Compare December 26, 2022 03:16
@Saschl Saschl marked this pull request as ready for review December 26, 2022 16:02
@tracernz
Copy link
Member

tracernz commented Jan 4, 2023

Fix lints.

@Saschl Saschl added the Exp Available on experimental branch (for testing) label Jan 4, 2023
@Saschl Saschl changed the title refactor: remove old js SD refactor: port SD to full react-based instrument Jan 4, 2023
igor8518 pushed a commit to igor8518/a32nx that referenced this pull request Jan 6, 2023
@dragold
Copy link

dragold commented Jan 9, 2023

QA Tester Report

Name: Mr.Blank#6197
Date of testing MM/DD/YYYY:01/09/2023
PR Tested: 7556
Tier of testing:1

Testing technique: tryouts
Test Instructions:
The logic of the screens has not been touched by this PR so we don't expect any visual changes. However, here some points that can be checked.
Make sure all pages are selectable and show correct/meaningful data.
Test ECAM ALL button (pages should cycle in a one-second interval)
Verify auto-switching behaviour when no page is selected (non exhaustive list following)
Deselect any active ecam page when C&D and turn on the API -> APU page should appear
Start the engines -> ENG page should show up
While taxiing, move any control surface fully and verify the F/CTL page is showing up. When releasing controls, page should switch back after 20s
In cruise, CRZ page should be shown
Ps--
General observation of any possible weird behavior.

Methodology
All as per instruction

Negatives: NIL
Testing Results: PASS
Conclusions: results were of normal outputs

@MicahBCode
Copy link
Contributor

Why don't you port the SD directly to the MSFS Avionics Framework, instead of React?

@Saschl
Copy link
Contributor Author

Saschl commented Jan 9, 2023

Will come eventually. First step is to get rid of the old pure JS remainders so we unblock some progress (updated build pipeline + remote displays). Port to msfs avionics will take a bit longer as I did not touch the actual pages here.

@Saschl Saschl enabled auto-merge (squash) January 10, 2023 18:27
@Saschl Saschl merged commit 010bd3e into flybywiresim:master Jan 10, 2023
@2hwk 2hwk added this to the v0.10.0 milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exp Available on experimental branch (for testing) Needs Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants