-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: port SD to full react-based instrument #7345
Conversation
SD on my phone, here we come |
f57a3da
to
b4af1c4
Compare
Fix lints. |
QA Tester Report Name: Mr.Blank#6197 Testing technique: tryouts Methodology Negatives: NIL |
Why don't you port the SD directly to the MSFS Avionics Framework, instead of React? |
Will come eventually. First step is to get rid of the old pure JS remainders so we unblock some progress (updated build pipeline + remote displays). Port to msfs avionics will take a bit longer as I did not touch the actual pages here. |
Fixes #[issue_no]
Summary of Changes
-[ ] ensure accuracy (font sizes, layout...)(later, when systems are in place)Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
Logic of the screens have not been touched by this PR so we don't expect any visual changes. However, here some points that can be checked.
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.