Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fmgc): string stars with non-runway-specific approaches #7332

Merged
merged 4 commits into from
Jul 22, 2022

Conversation

tracernz
Copy link
Member

@tracernz tracernz commented Jul 14, 2022

Fixes #[issue_no]

Summary of Changes

Couldn't string a STAR with a non-runway-specific approach e.g. ELRU2A to RNAV F at NZQN. This removes the STAR filtering for non-runway-specific approaches in the MCDU page, and allows stringing runway legs in the case where there is only one runway in the STAR.

IRL behaviour is unclear at this stage, and in trying to get a reference for this particular approach I found the IRL database for a particular airline actually doesn't have these approaches in it. We can revisit in future when we can get better references. I think there are three options I can foresee:

  • these approaches are never in the IRL database, in which case we should filter them out entirely,
  • these approaches are processed into multiple runway-specific approaches by the FMS database tools,
  • works as-is here

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Check that NZQN RNAV F or G can be strung with ELRUV2A. Check that regular approach/STAR combos you're familiar with work okay.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

IRL behaviour is unclear on this... tried to get refs but the particular approaches in question aren't in the IRL database
@tracernz tracernz added this to the v0.9.0 milestone Jul 14, 2022
@2hwk
Copy link
Member

2hwk commented Jul 16, 2022

Quality Assurance Report

Discord : 2Cas#1022
Object of testing: #7332
Tier of Testing : 1
Date : 16/07/2022

Testing Process:

  • Check that NZQN RNAV F or G can be strung with ELRUV2A. Check that regular approach/STAR combos you're familiar with work okay.
  • KLAS/26R RADYR2 BLAQQ DCT SHTNR ANJLL4 KLAX/24R
  • KFLL/28R REGAE1 PERMT AR16 ILM SBY J79 VILLS DPK DPK3 KBDL/24
  • ESGG/21 TOPLA3J TOPLA DCT PENOR N133 DOMAG T240 OGDAV OGDAV4T EPGD/29
  • YPAD/05 PANKI3 PANKI H247 CULIN Y59 RIVET RIVET3 YSSY (No Arrival Runway Selected)
  • SBGL/15 TIVRO1A TIVRO DCT IBDA1A SBSP/35L

Negatives:

  • N/A

Testing Results:
Passed

Will be added to next exp version, to be merged 1 week after if no issue.

@2hwk 2hwk added the Exp Available on experimental branch (for testing) label Jul 16, 2022
2hwk added a commit that referenced this pull request Jul 16, 2022
2hwk added a commit that referenced this pull request Jul 16, 2022
igor8518 pushed a commit to igor8518/a32nx that referenced this pull request Jul 17, 2022
2hwk added a commit that referenced this pull request Jul 17, 2022
@tracernz tracernz enabled auto-merge (squash) July 22, 2022 08:56
@tracernz tracernz merged commit c949aad into flybywiresim:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exp Available on experimental branch (for testing) QA Tier 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants