fix(ISIS): removes ability to change a bug if selected item is Off #7280
Conversation
| @@ -31,6 +31,9 @@ export const ISISDisplay: React.FC = () => { | |||
|
|
|||
| useInteractionEvent('A32NX_ISIS_KNOB_CLOCKWISE', () => { | |||
| lastPilotInput.current = Date.now(); | |||
There was a problem hiding this comment.
For anyone else reviewing, the XML only sends the event if bugs mode is active... 😅
|
Quality Assurance Report Discord: marcman86#4907 Testing Process:
Negatives: Bugs values flicker when changed (click and scroll). Not of this PR, same in experimental version. Testing Results: Passed Hope this helps :-) |
|
Quality Assurance Tester Report Discord : mico#3145 Testing Process: Negatives: Testing Results: Conclusions: |
|
@patmack14 Could you please still add an entry to CHANGELOG.md? |
Doh! (I knew I forgot somethin!) Will update it sometime tonight/early tomorrow. |
Done |
Fixes #[issue_no]
Summary of Changes
This issue was brought to my attention by @tracernz. When the ISIS bug selectors, it previously allowed you to set a bug that was "off" or not activated. This fix removes the ability to set a bug when said item is in the "off" state.
Screenshots (if necessary)
References
https://youtu.be/U1bCkxL1QmY?t=69
https://youtu.be/NvKIk8dQnvs?t=325
Additional context
Discord username (if different from GitHub):
@pat M
Testing instructions
Open the ISIS Bugs page and attempt to set a bug that is in the "OFF" state.
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.