fix(rmp): RMP behaviour and lights #7105

juliansebline · 2022-04-24T18:14:48Z

Fixes #344
Fixes #164
Fixes #5033
Fixes #4591

Summary of Changes

This commit fixes the RMPs/ACPs's behaviour (VHFs only), their electrical power and add VHF 3 voice/data mode.

Screenshots (if necessary)

References

Additional context

Thanks shomas#2719 for the pîctures in the real aircraft!

My discord: Julian Sebline#8476

Testing instructions

Keep in mind both RMPs and ACPs are independent

Open SimvarWatcher and load the config file found in the last comment.
At startup:
- CALL1 should be active on both sides
- VHF1/2 volumes knobs should be on with values 0.8 and 0.4 (respectively)
- Left RMP should be set with VHF1
- Right RMP should be set with VHF2
- Respective SEL light should not be lit
- Simvars RECEIVE ALL and RECIEVE ALL should be set to 1 (for vPilot)
On the left RMP, press VHF2 then VHF3
- The left SEL led AND word should lit in orange on both sides
- Back to VHF1, the lights should go off
On the right RMP, press VHF1 then VHF3
- The right SEL led AND word should lit in orange on both sides
- Back to VHF2, the lights should go off
On both sides, press VHF1/2/3 volume knobs
- Each knob should turn on/off independently
- All knobs can be on/off
- Respective simvar should be set to 1 IF at least one knob of each side is on
- Respective simvar should be set to 0 IF each knob of each side is off
- When off, rotate a knob should be harder (to simulate real behaviour)
On both sides, rotate VHF1/2/3 volume knobs
- Each knob should rotate independently
- Respective simvar should be set to the greatest value of both knobs
Turn off all volumes knobs
- Rotate them should not update their respective simvar
- Turn them on, the simvar should be updated with the value of the knob OR the max value between the two knobs if both on
On both sides, turn OFF all CALL (related to VHFs) push buttons
- Their respective light is off
- The simvars COM TRANSMIT are set to 0
- The simvars PILOT/COPILOT TRANSMITTER TYPE are set to 4 (None)
On both sides, turn ON all CALL (related to VHFs) push buttons
- It's NOT possible to have two or more CALL push button active on one RMP
- The simvars PILOT/COPILOT TRANSMITTER TYPE are set to 0 for COM1, 1 for COM2, 2 for COM3
- The respective simvars COM TRANSMIT are set to 1 if at least one of the respective push buttons is on
Push VHF3 on each RMP
- The word DATA should appear centered in the active window
- A frequency should appear in the standby window
Push the transfer key
- The text "VHF 3 VOICE" should appear on the ECAM (the underlying logic is not implemented yet)
- Push the transfer key once gain, the message should disappear
Rotate the knobs to change a frequency
- Frequency decimal can now return to 0 after .975 even if the integer is 136 (tested irl)

For this part, refer to this link

It is very likely points 12 and 13 fail the test. I have just realized I did not implement the "unusable mechanism". I will implement it in the second PR even though I don't know how it is in real life. I will make the frequency windows blank and knobs off.

Disconnect DC BUS 1 and AC BUS 1
- VHF 3 (knob and push button) should be unusable
Disconnect DC BUS 2 and AC BUS 2
- VHF 2 (knob and push button) should be unusable
- RMP 2 should be unusable

At this point, only VHF 1, RMP 1 and both ACPs should be usable. Engines, APU, GPU off.

Disconnect DC ESS BUS and AC ESS BUS
- Everything should be unusable

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

Make sure you are signed in to GitHub
Click on the Checks tab on the PR
On the left side, click on the bottom PR tab
Click on the A32NX download link at the bottom of the page

src/instruments/src/EWD/elements/PseudoFWC.tsx

juliansebline · 2022-04-26T22:52:11Z

Thank you for your comment/ Would you have the precise list of phases affected ? I cannot find it on the internet. I suppose CLB CRZ DESCENT ? Thank you De : Michael ***@***.***> Envoyé le :mercredi 27 avril 2022 00:46 À : ***@***.***> Cc : Julian ***@***.***>; ***@***.***> Objet :Re: [flybywiresim/a32nx] fix(rmp): RMP behavior and lights (PR #7105) @tracernz commented on this pull request. In src/instruments/src/EWD/elements/PseudoFWC.tsx<#7105 (comment)>:

@@ -1349,6 +1351,17 @@ const PseudoFWC: React.FC = () => {

sysPage: -1, side: 'RIGHT', }, + '0000690': // VHF 3 VOICE + { + flightPhaseInhib: [], + simVarIsActive: voiceVHF3 !== 0, Shouldn't that go in flightPhaseInhib? — Reply to this email directly, view it on GitHub<#7105 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACLV5F4QOPDBLKYLJN23NK3VHBW4BANCNFSM5UGSVFCQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

tracernz · 2022-04-27T09:10:16Z

Thank you for your comment/ Would you have the precise list of phases affected ? I cannot find it on the internet. I suppose CLB CRZ DESCENT ?

BehEh provided the code above.

Requested changes Co-authored-by: Benedict Etzel <[email protected]>

beheh · 2022-04-28T09:51:47Z

flybywire-aircraft-a320-neo/ModelBehaviorDefs/A32NX/AirlinerCommon.xml

@@ -430,7 +431,7 @@
                    <FREQUENCY>3</FREQUENCY>
                    <UPDATE_CODE>
                    (A:COM TRANSMIT:#Radio_ID#, Bool) if{
-                        #Button_ID# (&gt;L:XMLVAR_COM_Transmit_Channel)
+                        <!-- #Button_ID# (&gt;L:XMLVAR_COM_PANEL#ID#_Transmit_Channel) -->


Why is this part commented out? Do we still need it, or is it unnecessary? We should either remove it, or make it real code again, or if not explain in the comment why it's commented out.

I was not able to spot the purpose for these lines of code. To me, it was part of all the problems.

Thefore, just in case for the future, I left the condition only.

beheh · 2022-04-28T09:52:09Z

flybywire-aircraft-a320-neo/ModelBehaviorDefs/A32NX/AirlinerCommon.xml

+                <!-- (L:XMLVAR_COM_#ID#_#FREQ_ID#_Switch_Down) -->
+                <!-- #Button_ID# (L:XMLVAR_COM_Transmit_Channel) == or 100 * -->


Same as above - let's either remove the comment, make it real code again, or add a notice why it's a comment.

I've commented these two lines because I couldn't understand their purpose. I couldn't see any changes with or without. But, as I am a newbie on this project and this language, I don't want to delete code I don't understand.

src/instruments/src/RMP/Components/StandbyFrequency.tsx

src/instruments/src/RMP/Components/RadioPanelDisplay.tsx

src/instruments/src/Common/EWDMessages.tsx

src/instruments/src/EWD/elements/PseudoFWC.tsx

beheh · 2022-04-28T10:02:40Z

src/instruments/src/RMP/Components/RadioPanelDisplay.tsx

+    // // If the passed value prop is a number, we'll use formatFrequency to get string format.
+    let value = textDataModeVHF3;
+    let offsetx = '100%';
+
+    if (typeof props.value === 'number') {
+        if (props.value !== 0) {
+            value = formatFrequency(props.value);
+        }
+    } else {
+        value = props.value;
+    }
+
+    if (props.value === 0) {
+        offsetx = '85%';
+    }


This entire component feels a bit messy now. I expect one bug for example to be that if you're in data mode AND enable lights test, offsetx may be incorrectly at 85%.

How about something more like this:

interface Props { vale: string | number; dataMode?: boolean; }

if (lightsTest) { content = ( <text x={offsetx} y="52%"> 8.8.8.8.8.8 </text> ); } else if (props.dataMode) { content = ( <text x="85%" y="52%"> DATA </text> ); } else { content = ( <text x="100%" y="52%"> {value} </text> ); } return ( <svg className="rmp-svg"> {content} </svg> );

You are right. I'm gonna ask Shomas if he can check the behavior in the real airplane as well

Requested changes: code and VHF3 VOICE format Co-authored-by: Benedict Etzel <[email protected]>

Requested changes: code VHF3 voice Co-authored-by: Benedict Etzel <[email protected]>

Requested changes: textDataModeVHF3 to TEXT_DATA_MODE_VHF3

Removal of useless changelogs

.github/CHANGELOG.md

From 0.4.0 to 0.8.0 for another one

Implemented

juliansebline · 2022-08-03T13:23:49Z

Put these lines into a file with the extension .simvars and load it into the Watcher.

COM TRANSMIT:1,Bool,False
COM TRANSMIT:2,Bool,False
COM TRANSMIT:3,Bool,False
COM VOLUME:1,percent over 100,False
COM VOLUME:2,percent over 100,False
COM VOLUME:3,percent over 100,False
PILOT TRANSMITTER TYPE,Enum,False
COPILOT TRANSMITTER TYPE,Enum,False

…bline/a32nx into RMP_fix_behavior_lights

mico975 · 2022-08-08T20:44:31Z

Quality Assurance Tester Report

Discord : mico#3145
Object of testing: (#7105
Tier of Testing : 1
Date : 08/08/2022

Testing Process:

At startup:
CALL1 should be active on both sides - OK
VHF1/2 volumes knobs should be on with values 0.8 and 0.4 (respectively) - OK
Left RMP should be set with VHF1 - OK
Right RMP should be set with VHF2 - OK
Respective SEL light should not be lit - OK
Simvars RECEIVE ALL and RECIEVE ALL should be set to 1 (for vPilot) - OK

On the left RMP, press VHF2 then VHF3
The left SEL led AND word should lit in orange on both sides - OK
Back to VHF1, the lights should go off - OK

On the right RMP, press VHF1 then VHF3
The right SEL led AND word should lit in orange on both sides - OK
Back to VHF2, the lights should go off - OK

On both sides, press VHF1/2/3 volume knobs
Each knob should turn on/off independently - OK
All knobs can be on/off - OK
Respective simvar should be set to 1 IF at least one knob of each side is on - OK
Respective simvar should be set to 0 IF each knob of each side is off - OK
When off, rotate a knob should be harder (to simulate real behaviour) - OK

On both sides, rotate VHF1/2/3 volume knobs
Each knob should rotate independently - OK
Respective simvar should be set to the greatest value of both knobs - OK

Turn off all volumes knobs
Rotate them should not update their respective simvar - OK
Turn them on, the simvar should be updated with the value of the knob OR the max value between the two knobs if both on - OK

On both sides, turn OFF all CALL (related to VHFs) push buttons
Their respective light is off - OK
The simvars COM TRANSMIT are set to 0 - OK
The simvars PILOT/COPILOT TRANSMITTER TYPE are set to 4 (None) - OK

On both sides, turn ON all CALL (related to VHFs) push buttons
It's NOT possible to have two or more CALL push button active on one RMP - OK
The simvars PILOT/COPILOT TRANSMITTER TYPE are set to 0 for COM1, 1 for COM2, 3 for COM3 - OK
The respective simvars COM TRANSMIT are set to 1 if at least one of the respective push buttons is on - OK

Push VHF3 on each RMP
The word DATA should appear centered in the active window - OK
A frequency should appear in the standby window - OK

Push the transfer key
The text "VHF 3 VOICE" should appear on the ECAM (the underlying logic is not implemented yet) - OK
Push the transfer key once gain, the message should disappear - OK

Rotate the knobs to change a frequency
Frequency decimal can now return to 0 after .975 even if the integer is 136 (tested irl) - OK

Disconnect DC BUS 1 and AC BUS 1 - not tested
VHF 3 (knob and push button) should be unusable

Disconnect DC BUS 2 and AC BUS 2 - not tested
VHF 2 (knob and push button) should be unusable
RMP 2 should be unusable
At this point, only VHF 1, RMP 1 and both ACPs should be usable. Engines, APU, GPU off.

Disconnect DC ESS BUS and AC ESS BUS - not tested
Everything should be unusable

Negatives:
See above in testing process

Testing Results:
Passed (electrical system config still needs to be tested by someon)

Conclusions:
LGTM

2hwk · 2022-08-16T13:20:13Z

Disconnect DC BUS 1 and AC BUS 1

VHF 3 (knob and push button) should be unusable

Disconnect DC BUS 2 and AC BUS 2

VHF 2 (knob and push button) should be unusable
RMP 2 should be unusable
At this point, only VHF 1, RMP 1 and both ACPs should be usable. Engines, APU, GPU off.

Disconnect DC ESS BUS and AC ESS BUS

Everything should be unusable

Remaining items passed

fix: RMP behavior and lights [issue 344]

6a57e41

juliansebline changed the title ~~fix: RMP behavior and lights [issue 344]~~ fix(rmp): RMP behavior and lights Apr 25, 2022

beheh requested changes Apr 26, 2022

View reviewed changes

src/instruments/src/EWD/elements/PseudoFWC.tsx Outdated Show resolved Hide resolved

Update src/instruments/src/EWD/elements/PseudoFWC.tsx

f019154

Requested changes Co-authored-by: Benedict Etzel <[email protected]>

beheh requested changes Apr 28, 2022

View reviewed changes

juliansebline and others added 6 commits April 28, 2022 13:04

Update src/instruments/src/Common/EWDMessages.tsx

a0e4100

Requested changes: code and VHF3 VOICE format Co-authored-by: Benedict Etzel <[email protected]>

Update src/instruments/src/EWD/elements/PseudoFWC.tsx

6afb3ad

Requested changes: code VHF3 voice Co-authored-by: Benedict Etzel <[email protected]>

Update src/instruments/src/EWD/elements/PseudoFWC.tsx

17de4ef

Requested changes: code VHF3 voice Co-authored-by: Benedict Etzel <[email protected]>

Update RadioPanelDisplay.tsx

9789fdf

Requested changes: textDataModeVHF3 to TEXT_DATA_MODE_VHF3

Fix bug with ANN LT involved

f3402d3

Added comments about commented out code

ee6a67d

2hwk added this to the v0.9.0 milestone Apr 29, 2022

juliansebline added 3 commits April 29, 2022 20:57

Fix RMPs elec buses

8f8791a

add of SEL word backlight

8af8c8a

Default init of transmit and volume buttons

ba3aba3

This was referenced May 16, 2022

Audio Knob pushing itself down when respective MIC is selected #5033

Closed

SEL light on RMP comes on without a cause #4591

Closed

[RMP] Backup Tuning #4044

Closed

juliansebline added 4 commits May 19, 2022 19:34

fix SEL light behavior

ed0e999

fix SEL light behavior #2

e6d657b

Removal of commented out code

6e58fd6

SEL backlight code

a76d2d7

juliansebline mentioned this pull request May 26, 2022

feat(rmp): RMP navigation tuning #7241

Merged

71 tasks

2hwk added the QA Tier 1 label Jun 5, 2022

juliansebline added 2 commits June 7, 2022 09:04

Changelog

a0939a5

Merge branch 'flybywiresim:master' into master

e142e91

juliansebline added 2 commits June 21, 2022 20:54

Merge branch 'master' into RMP_fix_behavior_lights

788b2c7

Changelog update

72b2573

Removal of useless changelogs

beheh previously requested changes Jun 22, 2022

View reviewed changes

.github/CHANGELOG.md Outdated Show resolved Hide resolved

Changelog from 0.4.0 to 0.9.0 as requested

f44dca6

From 0.4.0 to 0.8.0 for another one

2hwk approved these changes Aug 2, 2022

View reviewed changes

Merge branch 'master' into RMP_fix_behavior_lights

5775465

juliansebline added 2 commits August 3, 2022 19:50

Fix COM3 Transmit + it is now possible to transmit on no COM

20560ad

Merge branch 'RMP_fix_behavior_lights' of https://github.com/julianse…

77833af

…bline/a32nx into RMP_fix_behavior_lights

juliansebline changed the title ~~fix(rmp): RMP behavior and lights~~ fix(rmp): RMP behaviour and lights Aug 3, 2022

Fix knob animation

08f7009

BlueberryKing added a commit that referenced this pull request Aug 7, 2022

fix(rmp): RMP behaviour and lights #7105 (@08f7009)

3a5c2e6

BlueberryKing added the Exp Available on experimental branch (for testing) label Aug 7, 2022

juliansebline added 2 commits August 8, 2022 23:38

Fix simvars when switching between CALLS p/b

f24083d

Comment

c400705

2hwk pushed a commit that referenced this pull request Aug 9, 2022

fix(rmp): RMP behaviour and lights #7105 (@08f7009)

63f21ab

2hwk added a commit that referenced this pull request Aug 9, 2022

fix(rmp): RMP behaviour and lights #7105 (@c4007054)

fd5ed2e

2hwk added a commit that referenced this pull request Aug 12, 2022

fix(rmp): RMP behaviour and lights #7105 (@806037ab)

85b81b7

2hwk added a commit that referenced this pull request Aug 12, 2022

fix(rmp): RMP behaviour and lights #7105 (@806037ab)

d61e9af

2hwk enabled auto-merge (squash) August 16, 2022 13:24

Merge branch 'master' into RMP_fix_behavior_lights

d2b34fc

2hwk disabled auto-merge August 16, 2022 13:25

2hwk enabled auto-merge (squash) August 16, 2022 13:29

2hwk merged commit f86d18f into flybywiresim:master Aug 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(rmp): RMP behaviour and lights #7105

fix(rmp): RMP behaviour and lights #7105

juliansebline commented Apr 24, 2022 •

edited

Loading

juliansebline commented Apr 26, 2022 via email

tracernz commented Apr 27, 2022

beheh Apr 28, 2022

juliansebline Apr 28, 2022

beheh Apr 28, 2022

juliansebline Apr 28, 2022

beheh Apr 28, 2022

juliansebline Apr 28, 2022 •

edited

Loading

juliansebline commented Aug 3, 2022 •

edited

Loading

mico975 commented Aug 8, 2022 •

edited

Loading

2hwk commented Aug 16, 2022 •

edited

Loading

		<!-- (L:XMLVAR_COM_#ID#_#FREQ_ID#_Switch_Down) -->
		<!-- #Button_ID# (L:XMLVAR_COM_Transmit_Channel) == or 100 * -->

fix(rmp): RMP behaviour and lights #7105

fix(rmp): RMP behaviour and lights #7105

Conversation

juliansebline commented Apr 24, 2022 • edited Loading

Summary of Changes

Screenshots (if necessary)

References

Additional context

Testing instructions

How to download the PR for QA

juliansebline commented Apr 26, 2022 via email

tracernz commented Apr 27, 2022

beheh Apr 28, 2022

Choose a reason for hiding this comment

juliansebline Apr 28, 2022

Choose a reason for hiding this comment

beheh Apr 28, 2022

Choose a reason for hiding this comment

juliansebline Apr 28, 2022

Choose a reason for hiding this comment

beheh Apr 28, 2022

Choose a reason for hiding this comment

juliansebline Apr 28, 2022 • edited Loading

Choose a reason for hiding this comment

juliansebline commented Aug 3, 2022 • edited Loading

mico975 commented Aug 8, 2022 • edited Loading

2hwk commented Aug 16, 2022 • edited Loading

juliansebline commented Apr 24, 2022 •

edited

Loading

juliansebline Apr 28, 2022 •

edited

Loading

juliansebline commented Aug 3, 2022 •

edited

Loading

mico975 commented Aug 8, 2022 •

edited

Loading

2hwk commented Aug 16, 2022 •

edited

Loading