Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vertical navigation v1 #7080

Merged
merged 47 commits into from
May 10, 2023
Merged

feat: vertical navigation v1 #7080

merged 47 commits into from
May 10, 2023

Conversation

aguther
Copy link
Contributor

@aguther aguther commented Apr 18, 2022

Fixes #856
Fixes #1475
Fixes #2293
Fixes #5211
Fixes #7944

Summary of Changes

This PR introduces the first step of the implementation of the vertical navigation capabilities of the Airbus A320. It implements the basic vertical prediction and guidance functions. Additional features and improvements to existing functionality will follow in future PRs.

The following features are implemented:

  • Accurate speed, altitude, time and fuel predictions in the MCDU for all phases of flight.
  • Vertical predictions on the navigation display in the form of pseudowaypoints.
  • Ability to program cruise steps in the MCDU.
  • Vertical guidance in managed modes during all phases of flight
  • Pause-at-T/D quality of life feature.

The following features are yet to come:

  • Vertical guidance for non-precision approaches, including FINAL APP and FLS.
  • Required Time of Arrival (RTA) functionality.
  • TOO STEEP PATH segments and markers in the MCDU.
  • MORE DRAG message on the PFD
  • Equitime-point functionality
  • More sophisticated temperature model (matching H3)
  • Optimum step alts functionality
  • Energy circle display on the ND
  • Accurate data acquisition from ADRs

Testing instructions

Because this is the first step of the vertical navigation integration, not all features are expected to work properly. A test should therefore not test for functional correctness, but check for any breaking issues. A breaking issue would be the MCDU crashing for example.

The test procedure should go through a full cold & dark startup and go through the flows included in a normal flight. A full flight would be ideal, but checking a few entries in the MCDU is also fine. This could include:

  • Inserting a route and performance figures so predictions are computed.
  • Inserting/modifying constraints
  • Inserting/modifying step altitudes
  • Inserting/modifying speed limit
  • Inserting/modifying winds

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@aguther aguther added Do Not Merge Exp Available on experimental branch (for testing) labels Apr 18, 2022
aguther pushed a commit that referenced this pull request Apr 18, 2022
aguther pushed a commit that referenced this pull request Apr 18, 2022
tracernz pushed a commit that referenced this pull request Apr 20, 2022
aguther pushed a commit that referenced this pull request Apr 20, 2022
aguther pushed a commit that referenced this pull request Apr 20, 2022
aguther pushed a commit that referenced this pull request Apr 20, 2022
aguther pushed a commit that referenced this pull request Apr 21, 2022
aguther pushed a commit that referenced this pull request Apr 21, 2022
aguther pushed a commit that referenced this pull request Apr 21, 2022
aguther pushed a commit that referenced this pull request Apr 21, 2022
aguther pushed a commit that referenced this pull request Apr 21, 2022
aguther pushed a commit that referenced this pull request Apr 21, 2022
BlueberryKing added a commit that referenced this pull request Apr 21, 2022
aguther pushed a commit that referenced this pull request Apr 22, 2022
aguther pushed a commit that referenced this pull request Apr 23, 2022
aguther pushed a commit that referenced this pull request Apr 23, 2022
aguther pushed a commit that referenced this pull request Apr 23, 2022
aguther pushed a commit that referenced this pull request Apr 24, 2022
aguther pushed a commit that referenced this pull request Apr 24, 2022
aguther pushed a commit that referenced this pull request Apr 25, 2022
aguther pushed a commit that referenced this pull request Apr 25, 2022
aguther pushed a commit that referenced this pull request Apr 26, 2022
Saschl pushed a commit that referenced this pull request May 8, 2023
@brewers10
Copy link

Quality Assurance Tester Report

Discord: brewers_10#5706
Object of testing: #7080
Tier of Testing: 1
Date: 09/05/2023

Testing Process:

Loaded from cold and dark at EGGP. Usual startup flows follows and departed towards EGLL. All of the following were testing below:

Inserting a route and performance figures so predictions are computed. - OK
Inserting/modifying constraints - OK
Inserting/modifying step altitudes - OK
Inserting/modifying speed limit - OK
Inserting/modifying winds - OK

Testing Results:
Passed

Conclusions:
LGTM. Fantastic effort from everyone involved. It's a real treat to fly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exp Available on experimental branch (for testing) QA Tier 1
Projects
None yet