Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cond): randomized starting positions for air conditioning selector knobs #6922

Closed

Conversation

rare-potato
Copy link
Contributor

@rare-potato rare-potato commented Mar 15, 2022

Fixes #3128

Summary of Changes

On plane load the air conditioning selector knobs will be set to positions other than 12 o'clock based on a multimodal distribution centered on the 11 o'clock, 12 o'clock, and 1 o'clock notches, with more weight on the 11 and 12 o'clock notches.

References

Additional context

Task List:

  • Get feedback on most common positions outside of the 12 o'clock position
  • Program the multimodal distribution
  • Determine if code should be implemented in a different place.
  • Make some temperature settings more common based on ambient air temperature(Should be a separate Issue and PR)
  • Finish Pull Request formatting

Discord username (if different from GitHub): Rare Potato#9693

Testing instructions

Load plane multiple times checking that the A/C Selector knobs change position based on the logged
"WASM: A/C Knob Rounded Variable"

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

remove the static starting positions for the cabin air conditioning selector knobs
(initial implementation) on plane load randomize air conditioner knob starting positions based on a normal distribution
@rare-potato
Copy link
Contributor Author

I'd really like some input on if the current changes are in an appropriate location in reference to src/fbw/src/FlyByWireInterface.cpp and src/fbw/src/FlyByWireInterface.h.

I personally feel that these are not the appropriate locations but am unsure of where else I could implement this.

@rare-potato rare-potato deleted the cabin-ac-knob-randomize branch March 15, 2022 22:57
@rare-potato rare-potato restored the cabin-ac-knob-randomize branch March 15, 2022 23:00
@rare-potato rare-potato reopened this Mar 15, 2022
@rare-potato rare-potato marked this pull request as ready for review March 15, 2022 23:00
@rare-potato rare-potato marked this pull request as draft March 15, 2022 23:03
@tracernz
Copy link
Member

Take a look in https://github.com/flybywiresim/a32nx/tree/master/src/systems. The readme there explains some basics. Drill into the systems and a320_systems directories to find the code.

This partially reverts commit 697fcf1
inappropriate location for logic
start of logic to randomized air conditioning knobs on aircraft load
@wpine215
Copy link
Member

Will this be revisited anytime soon?

@rare-potato
Copy link
Contributor Author

Yeah, I'll go ahead and mark this closed since it's been so long since I last worked on it. I might revisit the issue at a later date with a new PR on a later fork if someone else doesn't pick it up before hand.

@tracernz
Copy link
Member

It appeared this was pretty close? Did it just need rebased, or still some implementation left to do?

@rare-potato
Copy link
Contributor Author

rare-potato commented May 26, 2022

@tracernz It mainly needed to be finished rebasing implementing of the rebase from my initial implementation. If I recall correctly I had successfully moved the logic portion to Rust but was having difficulty understanding the airframe initialization dataflow and never got around to finding someone to help me better understand it.

In other words, I wasn't able to figure out how exactly when/where the initialization of the airframe occurred to set the appropriate SIMVARS but wouldn't repeat itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More realistic starting positions for AIRCOND knobs
3 participants