-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cond): randomized starting positions for air conditioning selector knobs #6922
feat(cond): randomized starting positions for air conditioning selector knobs #6922
Conversation
remove the static starting positions for the cabin air conditioning selector knobs
(initial implementation) on plane load randomize air conditioner knob starting positions based on a normal distribution
I'd really like some input on if the current changes are in an appropriate location in reference to src/fbw/src/FlyByWireInterface.cpp and src/fbw/src/FlyByWireInterface.h. I personally feel that these are not the appropriate locations but am unsure of where else I could implement this. |
Take a look in https://github.com/flybywiresim/a32nx/tree/master/src/systems. The readme there explains some basics. Drill into the systems and a320_systems directories to find the code. |
This partially reverts commit 697fcf1 inappropriate location for logic
start of logic to randomized air conditioning knobs on aircraft load
Will this be revisited anytime soon? |
Yeah, I'll go ahead and mark this closed since it's been so long since I last worked on it. I might revisit the issue at a later date with a new PR on a later fork if someone else doesn't pick it up before hand. |
It appeared this was pretty close? Did it just need rebased, or still some implementation left to do? |
@tracernz It mainly needed to be finished In other words, I wasn't able to figure out how exactly when/where the initialization of the airframe occurred to set the appropriate SIMVARS but wouldn't repeat itself. |
Fixes #3128
Summary of Changes
On plane load the air conditioning selector knobs will be set to positions other than 12 o'clock based on a multimodal distribution centered on the 11 o'clock, 12 o'clock, and 1 o'clock notches, with more weight on the 11 and 12 o'clock notches.
References
Additional context
Task List:
Make some temperature settings more common based on ambient air temperature(Should be a separate Issue and PR)Discord username (if different from GitHub): Rare Potato#9693
Testing instructions
Load plane multiple times checking that the A/C Selector knobs change position based on the logged
"WASM: A/C Knob Rounded Variable"
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.