Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cond): cabin temperature knobs center with scroll #6921

Merged
merged 8 commits into from
Mar 17, 2022

Conversation

rare-potato
Copy link
Contributor

@rare-potato rare-potato commented Mar 15, 2022

Fixes #1763

Summary of Changes

Sets the scroll wheel increment for the A/C knob to a value that evenly divides the knobs into 0.2°C increments and allows for the knobs to align with every notch around the knobs. Users will be able to scroll or click from max value (300) to min value (0) and still be able to center the knobs on the notches.

References

I was not able to find any specific reference to the notch indications in the documentation I was able to acquire. So to maintain accuracy with the actual plane, I asked in discord what the relative position of the knob was in relation to the measured zone temperatures. An individual with the A320 Type Rated Pilot role in discord confirmed my theory that every notch is 2°C, starting at 18°C and ending at 30°C.

Additional context

Discord username (if different from GitHub): Rare Potato#9693

Testing instructions

Load aircraft, start APU if not running, and monitor the values listed for the Air Conditioning knobs while adjusting the knobs with both the mouse wheel and the left mouse button. The variables should decrease and increase by 5, allowing the knobs to become centered on the marked notches around each knob.

Verify that the knobs are centered on the notches when moved to the COLD, 9 o'clock, 11 o'clock, 12 o'clock, 1 o'clock, 3 o'clock, and HOT positions.

The values for local variables A32NX_OVHD_COND_CKPT_SELECTOR_KNOB, A32NX_OVHD_COND_FWD_SELECTOR_KNOB, and A32NX_OVHD_COND_AFT_SELECTOR_KNOB, starting at COLD and ending at the HOT setting, should return:

• 0    (18 C/COLD)
• 25   (19 C/halfway between first notch and COLD)
• 50   (20 C/first notch)
• 75   (21 C/halfway between first and second notch)
• 100  (22 C/second notch)
• 125  (23 C/halfway between second and center notch)
• 150  (24 C/center notch)
• 175  (25 C/halfway between center and third notch)
• 200  (26 C/third notch)
• 225  (27 C/halfway between third and fourth notch)
• 250  (28 C/forth notch)
• 275  (29 C/halfway between fourth notch and HOT)
• 300  (30 C/HOT)

Verify that the vent vectors on the COND page of the ECAM do not pass above of below the C and H markings and display the position of the knobs approximately.

Notes:

  • the local variables for the current temperatures are A32NX_COND_CKPT_TEMP, A32NX_COND_FWD_TEMP and A32NX_COND_AFT_TEMP.
  • allowing the temperatures to stabilize on the COND ECAM page should provide the most accurate results when adjusting the knobs.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

rare-potato and others added 6 commits March 15, 2022 01:59
scrolling the air condition knobs with the mouse wheel will always be centered
air conditioning knobs increment at .2 degrees celcius with both click and mouse wheel interactions
range for air conditioning selector knobs on the air condition page on lower ecam correctly displays
selector knobs for the air conditioning units centered on plane/flight load
@rare-potato rare-potato marked this pull request as ready for review March 15, 2022 22:49
refactor unit test to work with new knob formatting
Copy link
Member

@tracernz tracernz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... cross-checked your temp vs. knob rotation values and they're accurate. 👍

@tracernz tracernz added this to the v0.8.0 milestone Mar 17, 2022
@ShadowFrost3
Copy link

Quality Assurance Tester Report

Object of testing: #6921
Tier of Testing:1
Date: 17/03/2022

Testing Process: Cold and dark
Knob increments in .2 / 5 units - checked
temp correlation at ends and middle point - checked

Negatives: PAIN (slow..... but consistent with the rest of the aircraft)
Testing Results: Passed

Conclusions: Not subject to the bug I found on another knob so nice!

@mico975
Copy link
Contributor

mico975 commented Mar 17, 2022

Quality Assurance Tester Report

Discord : mico#3145
Object of testing: #6921
Tier of Testing : 1
Date : 17/03/2022

Testing Process:
Verify that the knobs are centered on the notches when moved to the COLD, 9 o'clock, 11 o'clock, 12 o'clock, 1 o'clock, 3 o'clock, and HOT positions. - OK

Verify that the vent vectors on the COND page of the ECAM do not pass above of below the C and H markings and display the position of the knobs approximately. - OK

Negatives:
N/A

Testing Results:
Passed

Conclusions:
Feels good to me

@tracernz tracernz merged commit 52616ba into flybywiresim:master Mar 17, 2022
ErickSharp pushed a commit that referenced this pull request Apr 3, 2022
* fix: AIRCOND knobs center with mouse wheel

scrolling the air condition knobs with the mouse wheel will always be centered

* feat(cond): changelog

* fix(cond): click and scroll change at same increment

air conditioning knobs increment at .2 degrees celcius with both click and mouse wheel interactions

* fix(ecam): cond page gauge range is accurate

range for air conditioning selector knobs on the air condition page on lower ecam correctly displays

* fix(misc): aircon selector knob starting position centered

selector knobs for the air conditioning units centered on plane/flight load

* refactor: changelog

* refactor: update temperature knob unit test

refactor unit test to work with new knob formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cabin temperature knobs not centered
4 participants