-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cond): cabin temperature knobs center with scroll #6921
Conversation
scrolling the air condition knobs with the mouse wheel will always be centered
air conditioning knobs increment at .2 degrees celcius with both click and mouse wheel interactions
range for air conditioning selector knobs on the air condition page on lower ecam correctly displays
selector knobs for the air conditioning units centered on plane/flight load
refactor unit test to work with new knob formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... cross-checked your temp vs. knob rotation values and they're accurate. 👍
Quality Assurance Tester Report Object of testing: #6921 Testing Process: Cold and dark Negatives: PAIN (slow..... but consistent with the rest of the aircraft) Conclusions: Not subject to the bug I found on another knob so nice! |
Quality Assurance Tester Report Discord : mico#3145 Testing Process: Verify that the vent vectors on the COND page of the ECAM do not pass above of below the C and H markings and display the position of the knobs approximately. - OK Negatives: Testing Results: Conclusions: |
* fix: AIRCOND knobs center with mouse wheel scrolling the air condition knobs with the mouse wheel will always be centered * feat(cond): changelog * fix(cond): click and scroll change at same increment air conditioning knobs increment at .2 degrees celcius with both click and mouse wheel interactions * fix(ecam): cond page gauge range is accurate range for air conditioning selector knobs on the air condition page on lower ecam correctly displays * fix(misc): aircon selector knob starting position centered selector knobs for the air conditioning units centered on plane/flight load * refactor: changelog * refactor: update temperature knob unit test refactor unit test to work with new knob formatting
Fixes #1763
Summary of Changes
Sets the scroll wheel increment for the A/C knob to a value that evenly divides the knobs into 0.2°C increments and allows for the knobs to align with every notch around the knobs. Users will be able to scroll or click from max value (300) to min value (0) and still be able to center the knobs on the notches.
References
I was not able to find any specific reference to the notch indications in the documentation I was able to acquire. So to maintain accuracy with the actual plane, I asked in discord what the relative position of the knob was in relation to the measured zone temperatures. An individual with the
A320 Type Rated Pilot
role in discord confirmed my theory that every notch is 2°C, starting at 18°C and ending at 30°C.Additional context
Discord username (if different from GitHub): Rare Potato#9693
Testing instructions
Load aircraft, start APU if not running, and monitor the values listed for the Air Conditioning knobs while adjusting the knobs with both the mouse wheel and the left mouse button. The variables should decrease and increase by 5, allowing the knobs to become centered on the marked notches around each knob.
Verify that the knobs are centered on the notches when moved to the COLD, 9 o'clock, 11 o'clock, 12 o'clock, 1 o'clock, 3 o'clock, and HOT positions.
The values for local variables
A32NX_OVHD_COND_CKPT_SELECTOR_KNOB
,A32NX_OVHD_COND_FWD_SELECTOR_KNOB
, andA32NX_OVHD_COND_AFT_SELECTOR_KNOB
, starting at COLD and ending at the HOT setting, should return:Verify that the vent vectors on the COND page of the ECAM do not pass above of below the C and H markings and display the position of the knobs approximately.
Notes:
A32NX_COND_CKPT_TEMP
,A32NX_COND_FWD_TEMP
andA32NX_COND_AFT_TEMP
.How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.