-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a380x/flightmodel): adjust climb performance #9358
base: master
Are you sure you want to change the base?
fix(a380x/flightmodel): adjust climb performance #9358
Conversation
Tested some of the values you've amended the plane feels a bit sluggish at climb now. Gross weight of about 373tonnes and my climb was only 2000fpm during the climb from 10000feet to 15000feet with IAS 290knots on open climb. This value was more believable if the gross weight was around 500tonnes or more. |
Thanks for testing! I noticed the same thing indeed, this was due to an error in my tuning method. I will continue to work on it. |
d92d0d4
to
9663561
Compare
@BlueberryKing Let me know when you are done so we can do a formal code review Also changelog needed. |
Has the parameters been tested and merged with the supposed Another taxi thrust adjustment Cause i seem to see both pulls involve the same cfg. |
c66689a
to
bedbcf8
Compare
My changes are now on top of the PR you mention, so they shouldn't conflict. |
734f0c4
to
766d387
Compare
One test here and it looked very good to me. Although I don't have any data to base it on (other than comparison to the A32NX), the climb rates looked very believable. For my flight, FMS predicted FL 400 at REC MAX, and I got to FL 39.6 before the climb rate stayed below 300 fpm (one definition of REC MAX). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, thank you!
fbw-a32nx/src/systems/fmgc/src/guidance/vnav/climb/ClimbPathBuilder.ts
Outdated
Show resolved
Hide resolved
Thank you for the reviews! I will address your comments as soon as I can. |
This comment was marked as off-topic.
This comment was marked as off-topic.
766d387
to
3853f95
Compare
Do you need anymore data collecting on this, or just wait for an update? |
2292049
to
b5ccf0d
Compare
Quality Assurance Tester Trainee Report Discord Username : Matt Testing Process: Previous test copied with similar weights. Then a worst case max take off weight was performed to compare. Results are below. Both Tests: LFBO departure, runway 14R. Live weather, 4 degrees. Both tests to FL 360, flown on a direct heading without any turns. Tests flown one after the other, so weather was as close to similar as possible. Test 1 456.9 tonnes at take off (previous test repeat). Test 1 - repeat of previous test, altitudes and climb numbers below for reference: 250kts - 4,000ft - 2500FPM - THR 94.3 - N1 85.1 Sadly, I did not record the time to FL360 on the previous test I ran. However, for this test it was 26.41. The results are fairly similar to the previous test. Test 2, max takeoff weight. Next, I did a worst case scenario test with all the same test parameters, apart from this time at max take off weight. 509.4 tonnes at take off. Test 2 - Max takeoff weight, altitude and climb numbers below for reference: 250kts - 4,000ft - 2500FPM - THR 93.6 - N1 84 As you can see, the numbers were not significantly different, and the main change in FPM came around the mid to late teens. Time to FL360 at max takeoff weight was 27.35, less than a minute more then the previous test. For me, both of these numbers seem relatively accurate throughout the climb, but still seem to washout somewhat more than I would have thought in the 30,000ft area for the non-max TO weight test. For a max take off climb, I think these numbers seem quite accurate. As for the repeat test at 456 tonnes, maybe this lighter weight (relative to max) is where a little tweaking still needs to happen. Interested to hear the thoughts of others though. Clearly, this is all temp and conditions dependent, but at 4 deg C on take off, and clear skies both times, seems a little cooler than standard. I am on the fence about a pass/fail. I think this new method should be implemented soon, as it is a lot more accurate than previous versions. I think the max takeoff weight climb performance seems pretty spot on to me. Maybe lighter weights is a little low on FPM climb rate in the 30,000s, but nothing much. If it needs a little tweaking later on, it is much smaller tweaks than the current climb model. |
I have some bug which might help. One comment said under this topic said that the N1 is to low in Climb and Cruise. In my opinion this is true. In fact, the N1 should be higher in climb and cruise than the THR but hat isnt the case. I'm not sure if this has anything to do with the wrong engine model. I just wanted to say this in case it helps. |
If I may add my 2 cents here, and some points to consider before tuning too much on the engines. There are 2 major reasons why climb performance is currently exaggerated, especially if you are trying to compare YouTube footage with this rendition in MSFS, which in my opinion, may not require too much engine tuning.
So if those two things would be properly simulated, you would notice a much more realistic representation of the climb performance of the A380. I would recommend the next time you fly the FBW A380, look at the thrust CLB limit when taking off, and adjusting your V/S knob to match your EWD Limiting thrust with your THR %, instead of N1 %. However if you want more data, I can try and get some footage in a level-d sim next time |
Hi Thank you for your input. The lack of a derate option does indeed contribute to the problem. That's something that we can hopefully add in the future. Regarding 1., that should only be an issue of the thrust limit. The tuning is done by comparing the thrust output (or climb gradients equivalently) for a given N1 between the sim and a reference. The thrust limit then has to be adjusted such that the correct N1 values are indeed reached during the climb at the given conditions. And yes, indeed, the thrust limit indication is an N1 limitation rather than a THR% at the moment. This is incorrect. However, as long as it is an N1 limit that's applied to the N1 control loop, that is not much different from calculating an appropriate THR% limit and applying it to the THR% control loop, the resulting N1 is the same. So in short, we are working on adjusting the thrust output to more realistic levels. The tuning should hopefully not take too much longer. 😄 |
Alright, it looks like you guys have a good method to fix this issue. |
Regarding taxi thrusts on the A380, in real life they use around about a maximum of 15% THR and no more that 15% THR, even at the MTOW. So according to real world A380 Pilots, they only use a small amount of thrust to get moving at very heavy weights. |
This PR does not affect taxi thrust. Taxi thrust has already been adjusted with the assistance of IRL A380 pilots on the team. (The THR indication on the A380X is not accurately modeled yet.) |
b5ccf0d
to
163cbb6
Compare
I have made some further adjustments to the thrust output and thrust limits. The thrust output might be a bit too high at high altitudes now, but I prefer that for this initial adjustment PR. Feel free to give it a test! |
Fixes #9042
Summary of Changes
Tune engine thrust and drag model to be more accurate.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.