feat: reduce number of created versions

flxlabs · Mar 21, 2023 · 6f255f4 · 6f255f4
1 parent 3e29da1
commit 6f255f4
Show file tree

Hide file tree

Showing 5 changed files with 49 additions and 9 deletions.
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1,3 @@
+vendor/
+composer.lock
+resources/
diff --git a/src/PageElement.php b/src/PageElement.php
@@ -131,12 +131,20 @@ public function onAfterWrite()
         if (Versioned::get_stage() == Versioned::DRAFT && $this->isChanged("__Counter", DataObject::CHANGE_VALUE)) {
             foreach ($this->PageSections() as $section) {
                 $section->__Counter++;
-                $section->write();
+                if ($section->isLiveVersion()) {
+                    $section->write();
+                } else {
+                    $section->writeWithoutVersion();
+                }
             }
 
             foreach ($this->Parents() as $parent) {
                 $parent->__Counter++;
-                $parent->write();
+                if ($parent->isLiveVersion()) {
+                    $parent->write();
+                } else {
+                    $parent->writeWithoutVersion();
+                }
             }
         }
     }
@@ -148,7 +156,11 @@ public function onAfterDelete()
         if (Versioned::get_stage() == Versioned::DRAFT) {
             foreach ($this->PageSections() as $section) {
                 $section->__Counter++;
-                $section->write();
+                if ($section->isLiveVersion()) {
+                    $section->write();
+                } else {
+                    $section->writeWithoutVersion();
+                }
             }
         }
     }
@@ -158,7 +170,11 @@ public function onAfterArchive()
         if (Versioned::get_stage() == Versioned::DRAFT) {
             foreach ($this->PageSections() as $section) {
                 $section->__Counter++;
-                $section->write();
+                if ($section->isLiveVersion()) {
+                    $section->write();
+                } else {
+                    $section->writeWithoutVersion();
+                }
             }
         }
     }

diff --git a/src/PageElementSelfRel.php b/src/PageElementSelfRel.php
@@ -36,7 +36,11 @@ public function onAfterWrite()
 
 		if (!$this->__NewOrder && Versioned::get_stage() == Versioned::DRAFT) {
 			$this->Parent()->__Counter++;
-			$this->Parent()->write();
+			if ($this->Parent()->isLiveVersion()) {
+				$this->Parent()->write();
+			} else {
+				$this->Parent()->writeWithoutVersion();
+			}
 		}
 	}
 
@@ -46,7 +50,11 @@ public function onAfterDelete()
 
 		if (Versioned::get_stage() == Versioned::DRAFT) {
 			$this->Parent()->__Counter++;
-			$this->Parent()->write();
+			if ($this->Parent()->isLiveVersion()) {
+				$this->Parent()->write();
+			} else {
+				$this->Parent()->writeWithoutVersion();
+			}
 		}
 	}
 }
diff --git a/src/PageSection.php b/src/PageSection.php
@@ -68,7 +68,12 @@ public function onAfterWrite()
 
 		if (!$this->__isNew && Versioned::get_stage() == Versioned::DRAFT && $this->isChanged("__Counter", DataObject::CHANGE_VALUE)) {
 			$this->Parent()->__PageSectionCounter++;
-			$this->Parent()->write();
+			// Only create a new version when the previous one is <th></th>e published one.
+			if ($this->Parent()->isLiveVersion()) {
+				$this->Parent()->write();
+			} else {
+				$this->Parent()->writeWithoutVersion();
+			}
 		}
 	}
 

diff --git a/src/PageSectionPageElementRel.php b/src/PageSectionPageElementRel.php
@@ -36,7 +36,11 @@ public function onAfterWrite()
 
 		if (!$this->__NewOrder && Versioned::get_stage() == Versioned::DRAFT) {
 			$this->PageSection()->__Counter++;
-			$this->PageSection()->write();
+			if ($this->PageSection()->isLiveVersion()) {
+				$this->PageSection()->write();
+			} else {
+				$this->PageSection()->writeWithoutVersion();
+			}
 		}
 	}
 
@@ -46,7 +50,11 @@ public function onAfterDelete()
 
 		if (Versioned::get_stage() == Versioned::DRAFT) {
 			$this->PageSection()->__Counter++;
-			$this->PageSection()->write();
+			if ($this->PageSection()->isLiveVersion()) {
+				$this->PageSection()->write();
+			} else {
+				$this->PageSection()->writeWithoutVersion();
+			}
 		}
 	}
 }