Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prepare-c-flag): add noAnchestors option to config #9

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

Rocko1204
Copy link
Collaborator

Hi @azlam-abdulsalam

While I was at it, I immediately implemented the feature. I wrote the option in the pool config file, so we are a bit more flexible compared to a new flag. Documentation update will follow when I have the authorization for sfp-docs.

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at flxbl-sfp Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@6591083). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage        ?   45.98%           
=======================================
  Files           ?       72           
  Lines           ?     2801           
  Branches        ?      320           
=======================================
  Hits            ?     1288           
  Misses          ?     1488           
  Partials        ?       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azlam-abdulsalam
Copy link

Nice thanks @Rocko1204

@azlam-abdulsalam azlam-abdulsalam self-requested a review February 6, 2024 01:38
@azlam-abdulsalam azlam-abdulsalam added this to the February 2023 milestone Feb 6, 2024
Copy link

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare does not support -c flag for scratch org creation
2 participants