Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deploy): flow activation and deactivation during package installation #17

Merged
merged 11 commits into from
Feb 22, 2024
Merged

feat(deploy): flow activation and deactivation during package installation #17

merged 11 commits into from
Feb 22, 2024

Conversation

azlam-abdulsalam
Copy link

@azlam-abdulsalam azlam-abdulsalam commented Feb 15, 2024 •
edited
Loading

Automated flow activation and deployment in source packages

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at flxbl-sfp Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@azlam-abdulsalam azlam-abdulsalam marked this pull request as ready for review February 15, 2024 03:56
@azlam-abdulsalam azlam-abdulsalam marked this pull request as draft February 15, 2024 03:56
@azlam-abdulsalam azlam-abdulsalam added this to the February 2024 milestone Feb 15, 2024
@azlam-abdulsalam azlam-abdulsalam changed the title feat: flow activation and deletion in deployment feat(deploy): flow activation and deletion in deployment Feb 15, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8a881b) 46.29% compared to head (5f4214d) 46.29%.

❗ Current head 5f4214d differs from pull request most recent head 63b1602. Consider uploading reports for the commit 63b1602 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   46.29%   46.29%           
=======================================
  Files          73       73           
  Lines        2817     2817           
  Branches      322      322           
=======================================
  Hits         1304     1304           
  Misses       1488     1488           
  Partials       25       25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azlam-abdulsalam azlam-abdulsalam marked this pull request as ready for review February 21, 2024 03:36
@azlam-abdulsalam azlam-abdulsalam added enhancement New feature or request feature and removed enhancement New feature or request labels Feb 21, 2024
crazynammer
crazynammer approved these changes Feb 21, 2024
View reviewed changes
Copy link

@crazynammer crazynammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Rocko1204
Rocko1204 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@Rocko1204 Rocko1204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now its fine. In the next release small updates.

packages/sfp-cli/src/commands/flow/delete.ts Outdated Show resolved Hide resolved
packages/sfp-cli/src/commands/flow/delete.ts Outdated Show resolved Hide resolved
packages/sfp-cli/src/core/utils/FlowUtils.ts Outdated Show resolved Hide resolved
packages/sfp-cli/src/core/utils/FlowUtils.ts Outdated Show resolved Hide resolved
@azlam-abdulsalam azlam-abdulsalam changed the title feat(deploy): flow activation and deletion in deployment feat(deploy): flow activation and deactivation during package installation Feb 21, 2024
This was referenced Feb 22, 2024
Open
Open
@azlam-abdulsalam azlam-abdulsalam merged commit 05cb81f into main Feb 22, 2024
2 of 3 checks passed
This was referenced Jun 29, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rocko1204 Rocko1204 Rocko1204 approved these changes

@crazynammer crazynammer crazynammer approved these changes

@zhebinliu zhebinliu Awaiting requested review from zhebinliu

Assignees

@azlam-abdulsalam azlam-abdulsalam

Labels
feature
Projects
None yet
Milestone
February 2024
Development

Successfully merging this pull request may close these issues.
4 participants
@azlam-abdulsalam @crazynammer @Rocko1204 @zhebinliu