Skip to content

Commit

Permalink
build(lerna): upgrade lerna version (dxatscale#1357)
Browse files Browse the repository at this point in the history
* build(lerna): upgrade lerna version

Lerna v7 has been released which deprecates old workflows from before
package managers had workspace capabilities.

Workspaces are now used by default and the useWorkspaces property from
lerna.json has been removed.

This upgrades the dev dependency for lerna to v7 ensuring v7 is used in
ci, and includes changes to lerna.json and nx.json from running lerna
repair in the repository root.

* ci(lerna): removes lerna bootstrap from ci

Removes bootstrap as this is now deprecated in lerna v7.
  • Loading branch information
ethan-sargent authored Jul 18, 2023
1 parent 7a0cd39 commit a28534f
Show file tree
Hide file tree
Showing 5 changed files with 1,902 additions and 2,211 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,10 @@ jobs:
uses: actions/setup-node@v1
with:
node-version: '16.x'
registry-url: 'https://registry.npmjs.org'
registry-url: 'https://registry.npmjs.org'
- run: npm ci
- run: npx lerna bootstrap
- run: npx lerna run build
- run: npx lerna run test -- --colors
- run: bash <(curl -s https://codecov.io/bash) -v


10 changes: 3 additions & 7 deletions lerna.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
{
"packages": [
"packages/*"
],
"useWorkspaces": true,
"$schema": "node_modules/lerna/schemas/lerna-schema.json",
"packages": ["packages/*"],
"version": "independent",
"command": {
"publish": {
"yes": true,
"ignoreChanges": [
"*.md"
],
"ignoreChanges": ["*.md"],
"registry": "https://registry.npmjs.org",
"message": "chore(publish): update versions and publish to npm"
}
Expand Down
46 changes: 21 additions & 25 deletions nx.json
Original file line number Diff line number Diff line change
@@ -1,29 +1,25 @@
{
"tasksRunnerOptions": {
"default": {
"runner": "nx/tasks-runners/default",
"options": {
"cacheableOperations": [
"build",
"compile",
"test"
]
}
}
},
"targetDefaults": {
"build": {
"dependsOn": [
"^build"
],
"outputs": [
"{projectRoot}/lib"
]
"$schema": "./node_modules/nx/schemas/nx-schema.json",
"tasksRunnerOptions": {
"default": {
"runner": "nx/tasks-runners/default",
"options": {
"cacheableOperations": ["build", "compile", "test"]
}
}
},
"targetDefaults": {
"build": {
"dependsOn": ["^build"],
"outputs": ["{projectRoot}/lib"]
},
"compile": {
"outputs": ["{projectRoot}/lib"]
}
},
"compile": {
"outputs": [
"{projectRoot}/lib"
]
"namedInputs": {
"default": ["{projectRoot}/**/*", "sharedGlobals"],
"sharedGlobals": [],
"production": ["default"]
}
}
}
Loading

0 comments on commit a28534f

Please sign in to comment.