fix(artifact): undo earlier fix from #128

flxbl-io · Dec 16, 2024 · 2e138b0 · 2e138b0
1 parent cb28125
commit 2e138b0
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 73 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/core/artifacts/generators/ArtifactGenerator.ts b/src/core/artifacts/generators/ArtifactGenerator.ts
@@ -83,8 +83,9 @@ export default class ArtifactGenerator {
             );
 
             // Cleanup unzipped artifact
-            // rimraf.sync(artifactFilepath); // This gives an error in windows "Error: EPERM: operation not permitted, unlink" https://github.com/flxbl-io/sfp/issues/128
-            rimraf.moveRemoveSync(artifactFilepath);
+            // https://github.com/flxbl-io/sfp/issues/128
+            // Undo fix for #128, use a different approach as its failing in docker
+            await fs.remove(artifactFilepath);
 
             return zipArtifactFilepath;
         } catch (error) {