Add Cosign signing and verification to OCI docs #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
force-pushed
the
cosign-verify
branch
from
d18ca66 to
9ca43a2
Compare
11 tasks
stefanprodan
force-pushed
the
cosign-verify
branch
3 times, most recently
from
83d7138 to
225345c
Compare
hiddeco
reviewed
Sep 29, 2022
| Push and sign the artifact using the Cosign private key: | ||
|
|
||
| ```shell | ||
| flux push artifact oci://ghcr.io/stefanprodan/manifests/podinfo:$(git tag --points-at HEAD) \ |
There was a problem hiding this comment.
Maybe replace ghcr.io/... here with <image reference>? I see it is also used in the examples above, but would think it is easier for people to follow when they have guidance on what needs to be replaced. Instead of accidentally copying the command in full, then discovering they can not push to this image repository, to then figure out what needs replacing.
There was a problem hiding this comment.
The guide starts by telling people to clone podinfo, so maybe only the GH username could be a placeholder? I'm for doing this in a separate PR as it touches the whole guide.
darkowlzz
reviewed
Sep 29, 2022
Signed-off-by: Stefan Prodan <[email protected]>
stefanprodan
force-pushed
the
cosign-verify
branch
from
225345c to
fb39ad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Cosign signing and Flux verification to the OCI artifacts guide.
Part of: fluxcd/flux2#3155