Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: Fix issue with recurseSubmodules #975

Merged
merged 1 commit into from
Dec 12, 2022
Merged

git: Fix issue with recurseSubmodules #975

merged 1 commit into from
Dec 12, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Dec 6, 2022 •
edited
Loading

Underlying fix: fluxcd/pkg#419.

Fixes #970.

@pjbgf pjbgf added bug Something isn't working area/git Git related issues and pull requests labels Dec 6, 2022
@pjbgf pjbgf added this to the Bootstrap GA milestone Dec 6, 2022
@pjbgf pjbgf mentioned this pull request Dec 6, 2022
Closed
22 tasks
@stefanprodan
Copy link
Member

Can you please link to the PR in fluxcd/pkg that contains the actual fix. Have we added tests to make sure we don’t break the submodule feature in the future?

@pjbgf
Copy link
Member Author

pjbgf commented Dec 7, 2022

@stefanprodan the issue was with the Flux specific FS, it wasn't clear that chroot was a required feature. We added tests to ensure chroot is implemented and working as expected, so we should be covered by regression on that front.

stefanprodan
stefanprodan approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @pjbgf 🏅

@pjbgf pjbgf added the hold Issues and pull requests put on hold label Dec 7, 2022
@pjbgf
Copy link
Member Author

pjbgf commented Dec 7, 2022

Hold the merge whilst we reassess the feedback from the user.

@pjbgf pjbgf force-pushed the fix-chroot branch 2 times, most recently from 6202ada to d24afcf Compare December 12, 2022 12:47
@pjbgf pjbgf marked this pull request as draft December 12, 2022 12:52
@pjbgf pjbgf mentioned this pull request Dec 12, 2022
Closed
@pjbgf pjbgf marked this pull request as ready for review December 12, 2022 15:58
@pjbgf
Copy link
Member Author

pjbgf commented Dec 12, 2022

This has been confirmed to fix the linked issue.

@pjbgf pjbgf merged commit e877040 into main Dec 12, 2022
@pjbgf pjbgf deleted the fix-chroot branch December 12, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/git Git related issues and pull requests bug Something isn't working hold Issues and pull requests put on hold
Projects
Maintainers' Focus
Archived in project
Milestone
Bootstrap GA
Development

Successfully merging this pull request may close these issues.

Issue with recurseSubmodules on 0.37.1
2 participants
@pjbgf @stefanprodan