Enable panic recovery #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
reviewed
Aug 9, 2022
pjbgf
reviewed
Aug 10, 2022
pjbgf
reviewed
Aug 11, 2022
stefanprodan
changed the title
darkowlzz
reviewed
Aug 11, 2022
controllers/bucket_controller.go
Outdated
| @@ -125,6 +125,7 @@ type BucketReconciler struct { | |||
| type BucketReconcilerOptions struct { | |||
| MaxConcurrentReconciles int | |||
| RateLimiter ratelimiter.RateLimiter | |||
| RecoverPanic bool | |||
There was a problem hiding this comment.
We no longer need to add this option as we don't make this configurable.
|
@Santosh1176 Along with the last requested change, can you please squash all the commits into a single commit? |
…anic instead of crashing the controller and Squashed commits. Signed-off-by: Santosh Kaluskar <[email protected]>
Santosh1176
force-pushed
the
fix-2952/sc
branch
from
9af866a to
1ad2f00
Compare
stefanprodan
approved these changes
Aug 11, 2022
darkowlzz
approved these changes
Aug 11, 2022
pjbgf
approved these changes
Aug 11, 2022
|
@stefanprodan @pjbgf @darkowlzz Thank you for the opportunity and guidance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements RecoverPanic option on reconcilers.
This is a part fixes to issue #2952
…
Signed-off-by: Santosh Kaluskar [email protected]