Introduce storage abstraction and locking mechanism #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the same condition type as kubernetes/enhancements#1624 so it can be dropped in favour of the Kubernetes type when that PR is merged
- add storage and artifact types - extract fs operations to storage functions - construct artifact paths from Kubernetes objects metadata
- use storage helper in GitRepositoryReconciler - implement artifacts GC - rename status artifacts to artifact
hiddeco
approved these changes
Apr 10, 2020
- move checksum and file write operations to Storage - implement GC
hiddeco
approved these changes
Apr 10, 2020
stefanprodan
force-pushed
the
api-v1alpha1
branch
3 times, most recently
from
eca86a3
to
e7ff6b2
Compare
stefanprodan
changed the title
stefanprodan
force-pushed
the
api-v1alpha1
branch
from
e7ff6b2
to
d1f7699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
kubernetes/enhancements#1624so it can be dropped in favour of the Kubernetes type when that PR is merged