Implement helpers from pkg/runtime
#361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
refactor-reconcilers
branch
5 times, most recently
from
63d65f9 to
153d8a7
Compare
hiddeco
force-pushed
the
refactor-reconcilers
branch
2 times, most recently
from
28d93d0 to
b629c74
Compare
hiddeco
force-pushed
the
refactor-reconcilers
branch
6 times, most recently
from
cac5edb to
769ef73
Compare
hiddeco
force-pushed
the
refactor-reconcilers
branch
from
0a98410 to
e449b29
Compare
7 tasks
hiddeco
force-pushed
the
refactor-reconcilers
branch
6 times, most recently
from
e9b371b to
0dc3598
Compare
hiddeco
force-pushed
the
refactor-reconcilers
branch
from
6be9587 to
48365a1
Compare
This commit loosely implements the events and metrics helpers that have been newly introduced to `fluxcd/pkg/runtime`, and heavily reduces code duplication. It is in preparation of a much bigger overhaul to implement the work pending in fluxcd/pkg#101. While implementing, I ran into little annoyances that likely should be addressed before the "official" `runtime` MINOR release: - Passing `nil` every time there isn't any metadata for an event quickly becomes cumbersome; we should look into an `EventWithMetadata` and/or `EventfWithMetadata`, or some other way to _optionally_ provide metadata without annoying the consumer. - There is an inconsistency in the method names of the metric helper, i.e. `RecordReadinessMetric` vs `RecordSuspend`. We either need to append or remove the `Metric` suffix on all recording methods. Signed-off-by: Hidde Beydals <[email protected]>
During the writing of tests that now have end-to-end tests for both Git implementations, an inconsistency was discovered in the `libgit2` implementation, resulting in unaligned behavior in the parsing of tags. This commit aligns the implementation with the `gogit` one, so that they behave exactly the same. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
This includes the removal of the `internal/testenv` package, as this is now available in `pkg/runtime`. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
`io/ioutil` has been deprecated since Go 1.16, see: https://golang.org/doc/go1.16#ioutil Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
refactor-reconcilers
branch
2 times, most recently
from
6cd78ba to
f636875
Compare
This was referenced Jul 31, 2021
|
Superseded by all above PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: fluxcd/flux2#1601
(Incomplete) TODO