-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for .spec.proxySecretRef
for generic provider of Bucket API
#1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheuscscp
force-pushed
the
bucket-generic-proxy
branch
from
June 4, 2024 23:22
67343c2
to
585626e
Compare
matheuscscp
force-pushed
the
bucket-generic-proxy
branch
4 times, most recently
from
June 17, 2024 12:37
3d7db8a
to
da66e44
Compare
stefanprodan
added
area/bucket
Bucket related issues and pull requests
area/api
API related issues and pull requests
labels
Jun 17, 2024
matheuscscp
force-pushed
the
bucket-generic-proxy
branch
2 times, most recently
from
June 18, 2024 11:48
9f00810
to
02fea49
Compare
matheuscscp
force-pushed
the
bucket-generic-proxy
branch
from
June 19, 2024 12:25
02fea49
to
99c3701
Compare
matheuscscp
force-pushed
the
bucket-generic-proxy
branch
from
June 19, 2024 13:16
99c3701
to
c591823
Compare
matheuscscp
force-pushed
the
bucket-generic-proxy
branch
from
June 19, 2024 22:26
c591823
to
af1652b
Compare
matheuscscp
force-pushed
the
bucket-generic-proxy
branch
2 times, most recently
from
June 19, 2024 22:49
5de61f0
to
ce93f13
Compare
matheuscscp
force-pushed
the
bucket-generic-proxy
branch
2 times, most recently
from
June 23, 2024 07:14
95ee307
to
11893b4
Compare
darkowlzz
reviewed
Jun 25, 2024
darkowlzz
reviewed
Jun 25, 2024
darkowlzz
reviewed
Jun 25, 2024
matheuscscp
force-pushed
the
bucket-generic-proxy
branch
4 times, most recently
from
June 28, 2024 14:55
ea7b75f
to
540e38c
Compare
matheuscscp
force-pushed
the
bucket-generic-proxy
branch
10 times, most recently
from
June 28, 2024 20:25
3eba1e2
to
6f546d9
Compare
darkowlzz
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks.
Signed-off-by: Matheus Pimenta <[email protected]>
matheuscscp
force-pushed
the
bucket-generic-proxy
branch
from
July 3, 2024 14:10
6f546d9
to
4d9c87c
Compare
stefanprodan
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @matheuscscp 🏅
stefanprodan
changed the title
Add support for .spec.proxySecretRef for generic provider of Bucket API
Add support for Jul 3, 2024
.spec.proxySecretRef
for generic provider of Bucket API
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1493