Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .spec.proxySecretRef for generic provider of Bucket API #1500

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

matheuscscp
Copy link
Member

@matheuscscp matheuscscp commented Jun 4, 2024

Fixes #1493

@matheuscscp matheuscscp force-pushed the bucket-generic-proxy branch from 67343c2 to 585626e Compare June 4, 2024 23:22
@matheuscscp matheuscscp force-pushed the bucket-generic-proxy branch 4 times, most recently from 3d7db8a to da66e44 Compare June 17, 2024 12:37
@stefanprodan stefanprodan added area/bucket Bucket related issues and pull requests area/api API related issues and pull requests labels Jun 17, 2024
@matheuscscp matheuscscp force-pushed the bucket-generic-proxy branch 2 times, most recently from 9f00810 to 02fea49 Compare June 18, 2024 11:48
@matheuscscp matheuscscp marked this pull request as ready for review June 18, 2024 11:55
@matheuscscp matheuscscp force-pushed the bucket-generic-proxy branch from 02fea49 to 99c3701 Compare June 19, 2024 12:25
@matheuscscp matheuscscp force-pushed the bucket-generic-proxy branch from 99c3701 to c591823 Compare June 19, 2024 13:16
@matheuscscp matheuscscp force-pushed the bucket-generic-proxy branch from c591823 to af1652b Compare June 19, 2024 22:26
pkg/minio/minio.go Fixed Show resolved Hide resolved
@matheuscscp matheuscscp force-pushed the bucket-generic-proxy branch 2 times, most recently from 5de61f0 to ce93f13 Compare June 19, 2024 22:49
@matheuscscp matheuscscp requested a review from stefanprodan June 19, 2024 22:58
@matheuscscp matheuscscp force-pushed the bucket-generic-proxy branch 2 times, most recently from 95ee307 to 11893b4 Compare June 23, 2024 07:14
pkg/minio/minio.go Outdated Show resolved Hide resolved
pkg/minio/minio_test.go Show resolved Hide resolved
pkg/minio/minio.go Outdated Show resolved Hide resolved
@matheuscscp matheuscscp force-pushed the bucket-generic-proxy branch 4 times, most recently from ea7b75f to 540e38c Compare June 28, 2024 14:55
@matheuscscp matheuscscp force-pushed the bucket-generic-proxy branch 10 times, most recently from 3eba1e2 to 6f546d9 Compare June 28, 2024 20:25
@matheuscscp matheuscscp requested a review from darkowlzz June 28, 2024 23:24
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks.

@matheuscscp matheuscscp force-pushed the bucket-generic-proxy branch from 6f546d9 to 4d9c87c Compare July 3, 2024 14:10
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp 🏅

@stefanprodan stefanprodan changed the title Add support for .spec.proxySecretRef for generic provider of Bucket API Add support for .spec.proxySecretRef for generic provider of Bucket API Jul 3, 2024
@stefanprodan stefanprodan merged commit c7e8330 into fluxcd:main Jul 3, 2024
9 checks passed
@matheuscscp matheuscscp deleted the bucket-generic-proxy branch July 3, 2024 14:20
@stefanprodan stefanprodan added this to the Bucket GA milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api API related issues and pull requests area/bucket Bucket related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying HTTP/S proxy in Bucket API
3 participants