Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply default permission mode to all files/dirs in an artifact archive #1020

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

makkes
Copy link
Member

@makkes makkes commented Feb 3, 2023

closes #1019

@makkes makkes requested a review from hiddeco February 3, 2023 15:52
@makkes makkes self-assigned this Feb 3, 2023
controllers/storage.go Outdated Show resolved Hide resolved
@makkes makkes force-pushed the default-mode-archive-files branch from 7438414 to ece4134 Compare February 3, 2023 16:50
@makkes makkes changed the title Apply default mode of 0644 to all files in an artifact archive Apply default permission mode to all files/dirs in an artifact archive Feb 3, 2023
@makkes makkes force-pushed the default-mode-archive-files branch from ece4134 to 717d125 Compare February 3, 2023 16:55
@makkes makkes requested a review from hiddeco February 3, 2023 17:01
controllers/storage.go Outdated Show resolved Hide resolved
@makkes makkes force-pushed the default-mode-archive-files branch from 717d125 to 27eaebe Compare February 3, 2023 18:11
@stefanprodan stefanprodan added the area/storage Storage related issues and pull requests label Feb 4, 2023
@makkes makkes requested a review from hiddeco February 4, 2023 11:10
@hiddeco
Copy link
Member

hiddeco commented Feb 6, 2023

Think this needs to wait until next minor as it causes the storage to produce different checksums.

Files: 0644
Directories: 0755

closes #1019

Signed-off-by: Max Jonas Werner <[email protected]>
@hiddeco hiddeco force-pushed the default-mode-archive-files branch from 27eaebe to bfa61d9 Compare February 14, 2023 13:44
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot @makkes 🥇

@hiddeco hiddeco added the enhancement New feature or request label Feb 14, 2023
@hiddeco hiddeco merged commit 2bd0b41 into main Feb 14, 2023
@hiddeco hiddeco deleted the default-mode-archive-files branch February 14, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage Storage related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All OCI artifact files must be user-writable in order for kustomize controller to use them
4 participants