Adopt k8s standardized conditions in apis/meta #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relu
commented
Nov 1, 2020
apis/meta/conditions.go
Outdated
|
|
||
| // GetCondition returns the Condition from the given slice that matches the | ||
| // given type. | ||
| func GetCondition(conditions []Condition, conditionType string) *Condition { |
There was a problem hiding this comment.
Uncertain if to keep this and refactor so it's just a wrapper for FindStatusCondition or just ditch it (as is done now) and switch to that one directly where applicable.
There was a problem hiding this comment.
I think this is fine, we should be using FindStatusCondition.
hiddeco
reviewed
Nov 2, 2020
Use the newly introduced standardized Condition type kubernetes/enhancements#1624 Signed-off-by: Aurel Canciu <[email protected]>
Signed-off-by: Aurel Canciu <[email protected]>
Signed-off-by: Aurel Canciu <[email protected]>
relu
force-pushed
the
adopt-k8s-conditions
branch
from
21c5512
to
20138fb
Compare
|
Question: once this is out, will consumer API packages need a version bump (e.g. from v1alpha1 to v1alpha2)? My hunch is that it's not the case considering the interface is preserved (aside from the addition of the ObservedGeneration and that should ensure backward compatibility I assume. Example: fluxcd/image-reflector-controller#41 |
|
@relu this is not a break change so I would keep all the APIs versions as they are. |
hiddeco
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the newly introduced standardized Condition type kubernetes/enhancements#1624
Relates to fluxcd/flux2#225