Replaces kubectl field managers with the resource manager owner in ssa apply #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssa/patch.go
Outdated
| @@ -91,6 +91,38 @@ func patchRemoveFieldsManagers(object *unstructured.Unstructured, managers []Fil | |||
| return append(patches, newPatchReplace("/metadata/managedFields", entries)) | |||
| } | |||
|
|
|||
| // patchReplaceFieldsManagers returns a jsonPatch array for replacing the managers with matching prefix and operation type | |||
| // with another manager name and an apply operation. | |||
There was a problem hiding this comment.
Suggested change
| // with another manager name and an apply operation. | |
| // with the specified manager name and an apply operation. |
ssa/patch.go
Outdated
| entries = append(entries, entry) | ||
| } | ||
|
|
||
| if len(entries) == len(objEntries) && !renamed { |
There was a problem hiding this comment.
Suggested change
| if len(entries) == len(objEntries) && !renamed { | |
| if !renamed { |
ssa/patch.go
Outdated
| return nil | ||
| } | ||
|
|
||
| if len(entries) == 0 { |
There was a problem hiding this comment.
Delete this condition, it was needed for remove but not here.
|
@somtochiama can you please rebase and squash your commits. |
Signed-off-by: Somtochi Onyekwere <[email protected]>
somtochiama
force-pushed
the
new-manger
branch
from
092ffc0 to
d5ab2c5
Compare
stefanprodan
approved these changes
Jan 20, 2022
stefanprodan
added
the
area/server-side-apply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Somtochi Onyekwere [email protected]