Warn when secrets are not decrypted before apply #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
added
enhancement
hiddeco
reviewed
Nov 8, 2021
hiddeco
reviewed
Nov 8, 2021
| @@ -288,3 +289,13 @@ func isDir(path string) (bool, error) { | |||
|
|
|||
| return fileInfo.IsDir(), nil | |||
| } | |||
|
|
|||
| // IsEncryptedSecret checks if the given object is a Kubernetes Secret encrypted with Mozilla SOPS. | |||
| func IsEncryptedSecret(object *unstructured.Unstructured) bool { | |||
If decryption is not enabled, SOPS encrypted secrets will fail to apply with a validation error that doesn't give any hints. It's better to exit early and throw an error that tells users to enable decryption. Signed-off-by: Stefan Prodan <[email protected]>
stefanprodan
force-pushed
the
warn-about-sops-secrets
branch
from
01f021b to
4958b9c
Compare
hiddeco
approved these changes
Nov 8, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If decryption is not enabled, SOPS encrypted secrets will fail to apply with a validation error that doesn't give any hints. It's better to exit early and throw an error that tells users to enable decryption.