Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor predicates and enqueuers #156

Merged
merged 2 commits into from
Oct 28, 2020
Merged

Refactor predicates and enqueuers #156

merged 2 commits into from
Oct 28, 2020

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Oct 28, 2020 •
edited
Loading

  • Bundle predicates into SourceRevisionChangePredicate
  • Compare artifact <> Kustomizations in enqueuers

@hiddeco hiddeco force-pushed the refactor-predicates-enqueuers branch from db57728 to 5b47c08 Compare October 28, 2020 20:58
@hiddeco
Compare artifact <> Kustomizations in enqueuers
26db48b 
The reason for this is the `EnqueueRequestsFromMapFunc` calling the
enqueuer for _both_ the old and the new object, and we only want to act
on the ones that contain a revision different from the one that we have
recorded in the status object of the `Kustomization`.

Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco hiddeco force-pushed the refactor-predicates-enqueuers branch from 5b47c08 to 26db48b Compare October 28, 2020 21:36
@hiddeco hiddeco marked this pull request as ready for review October 28, 2020 21:37
@hiddeco hiddeco requested a review from stefanprodan October 28, 2020 21:38
stefanprodan
stefanprodan approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco

@hiddeco hiddeco merged commit 5f76a28 into main Oct 28, 2020
@hiddeco hiddeco deleted the refactor-predicates-enqueuers branch October 28, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiddeco @stefanprodan