Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move controllers to internal/controllers #362

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

aryan9600
Copy link
Member

@aryan9600 aryan9600 requested a review from stefanprodan March 27, 2023 16:42
@aryan9600 aryan9600 force-pushed the internal-controllers branch from fb92b2c to 82b8cb7 Compare March 27, 2023 16:44
mkdir -p controllers/testdata/crd
cp config/crd/bases/*.yaml controllers/testdata/crd
mkdir -p internal/controllers/testdata/crd
cp config/crd/bases/*.yaml internal/controllers/testdata/crd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the repo dirty, please add internal/controllers/testdata/crd to gitignore

@aryan9600 aryan9600 force-pushed the internal-controllers branch from 82b8cb7 to 519cd24 Compare March 27, 2023 17:00
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @aryan9600 🥇

@stefanprodan stefanprodan merged commit 7c28183 into fluxcd:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants