Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container Registry on 5005 port #220

Closed
lczerepuk opened this issue Jan 18, 2022 · 4 comments · Fixed by #222
Closed

Container Registry on 5005 port #220

lczerepuk opened this issue Jan 18, 2022 · 4 comments · Fixed by #222
Assignees
@relu
Labels
bug Something isn't working

Comments

@lczerepuk
Copy link

lczerepuk commented Jan 18, 2022 •
edited
Loading

Hello,

I have deployed image-reflector-controller with version: ghcr.io/fluxcd/image-reflector-controller:v0.15.0
When I want to create ImageRepository with port 5005, eg. git.mydomain.com:5005/foo/bar I got message:

✗ .spec.image value should not start with URL scheme; remove 'git.mydomain.com://'

How to fix this?

Ps. Version v0.14.0 works fine.
@stefanprodan stefanprodan added the bug Something isn't working label Jan 18, 2022
@squaremo squaremo mentioned this issue Jan 18, 2022
Merged
@relu relu self-assigned this Jan 18, 2022
relu added a commit that referenced this issue Jan 18, 2022
@relu
Fix schema validation check when using host:port
d424c8c 
The validation check for the presence of a schema did not take into
account situations when the registry hostname would be accompanied by a
port number. In this situation the hostname would be erroneously parsed
as a schema and validation would fail.

Fixes #220

Signed-off-by: Aurel Canciu <[email protected]>
relu added a commit that referenced this issue Jan 18, 2022
@relu
Fix scheme validation check when using host:port
a467fd7 
The validation check for the presence of a scheme did not take into
account situations when the registry hostname would be accompanied by a
port number. In this situation the hostname would be erroneously parsed
as a scheme and validation would fail.

Fixes #220

Signed-off-by: Aurel Canciu <[email protected]>
@relu relu mentioned this issue Jan 18, 2022
Merged
@surskitt
Copy link

I'm trying to run the automatic image update also with a private repository on a non-standard port, facing the same issue.

relu added a commit that referenced this issue Jan 20, 2022
@relu
Fix scheme validation check when using host:port
9dc5694 
The validation check for the presence of a scheme did not take into
account situations when the registry hostname would be accompanied by a
port number. In this situation the hostname would be erroneously parsed
as a scheme and validation would fail.

Fixes #220

Signed-off-by: Aurel Canciu <[email protected]>
@kingdonb
Copy link
Member

There is a resolution for this issue in process of being merged, see #222 👍

relu added a commit that referenced this issue Jan 31, 2022
@relu
Fix scheme validation check when using host:port
4dd87b8 
The validation check for the presence of a scheme did not take into
account situations when the registry hostname would be accompanied by a
port number. In this situation the hostname would be erroneously parsed
as a scheme and validation would fail.

Fixes #220

Signed-off-by: Aurel Canciu <[email protected]>
@lczerepuk
Copy link
Author

When can I expect new version release with this fix ?

@stefanprodan
Copy link
Member

This week we'll release flux 0.26 that will include this fix, you can subscribe to this issue fluxcd/flux2#2308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@relu relu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix scheme validation check when using host:port fluxcd/image-reflector-controller
5 participants
@relu @surskitt @kingdonb @stefanprodan @lczerepuk