Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source controller to improve managed transport #346

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Apr 8, 2022

Stability and reliability improvements

  • Retry on stale connections: fixes the issue of long-running connections resulting in EOF for GitLab servers. Although this may also affect other Git Servers in different scenarios.
  • Handle closing of stale connections: dispose resources and remove connection from cache.
  • Optimise mutex on cached connections for decreased waiting time when competing go-routines try to create a SSH connection.

Low Impact Breaking Changes

  • HTTP(S) URLs must be 2048 characters long.
  • SSH Path must be 4096 characters long.

xref: fluxcd/source-controller#658

@pjbgf pjbgf force-pushed the update-sc-transport branch from 60108e3 to 2b15793 Compare April 12, 2022 11:41
@pjbgf pjbgf marked this pull request as ready for review April 12, 2022 11:41
- source-controller to v0.23.0
- pkg/runtime to v0.14.0

Signed-off-by: Paulo Gomes <[email protected]>
@pjbgf pjbgf force-pushed the update-sc-transport branch from 2b15793 to cb790f8 Compare April 12, 2022 11:43
@stefanprodan stefanprodan added the area/ci CI related issues and pull requests label Apr 12, 2022
@pjbgf pjbgf merged commit ed166b2 into fluxcd:main Apr 12, 2022
@pjbgf pjbgf deleted the update-sc-transport branch April 12, 2022 12:01
@pjbgf pjbgf added this to the GA milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants