FOSSA scan enabled #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stefanprodan fixed, thanks :) |
|
@idvoretskyi not quite, pull requests will be made against main not master 😉 |
|
@stefanprodan yep, fixed! |
|
@idvoretskyi would you mind updating your PR once more, maybe squashing the three commits into one and also signing-off so DCO passes? Thank you! |
Signed-off-by: Ihor Dvoretskyi <[email protected]>
squaremo
force-pushed
the
idvoretskyi-fossa
branch
from
6eb0c44 to
1496c92
Compare
|
Rebased on main, and into one commit 🐟 |
stefanprodan
approved these changes
Jan 6, 2021
relu
reviewed
Jan 6, 2021
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: "^1.14.x" |
There was a problem hiding this comment.
Not sure if important/relevant. Should we go with 1.15? 😉
There was a problem hiding this comment.
:-) Let's fix it in post (so we can get Ihor's PR merged and not ask more of them)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref.: cncf/foundation#109
Signed-off-by: Ihor Dvoretskyi [email protected]