Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Expose the number of Helm Operator managed releases #387

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Expose the number of Helm Operator managed releases #387

merged 1 commit into from
Apr 21, 2020

Conversation

sa-spag
Copy link
Contributor

@sa-spag sa-spag commented Apr 21, 2020

Closes #344.

@sa-spag
Copy link
Contributor Author

sa-spag commented Apr 21, 2020 •
edited
Loading

Actually I'm wondering if it would make more sense to set the gauge on InstallAction and UninstallAction from https://github.com/fluxcd/helm-operator/blob/master/pkg/release/release.go#L240, so we track actual releases instead of HelmReleases. Though it won't be enough to take into account previously installed releases.

hiddeco
hiddeco approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@hiddeco hiddeco merged commit c0ca573 into fluxcd:master Apr 21, 2020
@sa-spag sa-spag deleted the prom-release-count branch April 21, 2020 11:44
@hiddeco hiddeco added this to the 1.1.0 milestone May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Expose a number of Helm Operator managed releases gauge
2 participants
@sa-spag @hiddeco