This repository was archived by the owner on Nov 1, 2022. It is now read-only.
release: introduce reuse-values functionality #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a fix of a regression bug, or faulty description of a feature. In a previous version of the Helm Operator the `ResetValues` option was introduced to make Helm reset the values to the chart defaults during an upgrade. In a later version this behaviour changed, and values were reset by default (as expected given a HelmRelease resource should be the sole truth). This commit adds the possibility to reuse values from previous releases by explicitly setting `.spec.resetValues` to `false`. This will make an upgrade made by the operator behave as if the `--reuse-values` flag would be set on an `helm upgrade` command. Removing this defintion from the HelmRelease, or setting `.resetValues` to true will make the operator change back to its default behaviour during subsquent upgrades made for the release.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a fix of a regression bug, or faulty description of a
feature.
In a previous version of the Helm Operator the
ResetValuesoptionwas introduced to make Helm reset the values to the chart defaults
during an upgrade. In a later version this behaviour changed, and
values were reset by default (as expected given a HelmRelease
resource should be the sole truth).
This commit adds the possibility to reuse values from previous
releases by explicitly setting
.spec.resetValuestofalse. Thiswill make an upgrade made by the operator behave as if the
--reuse-valuesflag would be set on anhelm upgradecommand.Removing this defintion from the HelmRelease, or setting
.resetValuesto true will make the operator change back to itsdefault behaviour during subsquent upgrades made for the release.
Fixes #352