This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Generate Helm chart and deploy/ CRD(s) using controller-gen
#270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
added
enhancement
hiddeco
force-pushed
the
enhancement/crd-generation
branch
2 times, most recently
from
35546ec to
542289b
Compare
stefanprodan
reviewed
Feb 5, 2020
| # we also need to populate vendor | ||
| hack/go_container.sh go mod tidy | ||
| hack/go_container.sh go mod vendor | ||
| export GO111MODULE="off" |
There was a problem hiding this comment.
Do we need this for Kubernetes > 1.16?
There was a problem hiding this comment.
No idea, and worth and investigation, but probably better to do this in a separate PR.
hiddeco
force-pushed
the
enhancement/crd-generation
branch
from
542289b to
1d38a73
Compare
hiddeco
force-pushed
the
enhancement/crd-generation
branch
from
1d38a73 to
f9310c1
Compare
This commit prepares the API types for CRD generation using `controller-gen` (https://github.com/kubernetes-sigs/controller-tools). Generating the CRDs instead of maintaining them by hand offers us a list of improvements, and will improve the overall quality of our CRDs and the documentation that comes with it. Some of the improvements are: * Future management and upgrading of the CRD(s) will be easier as `controller-gen` is able to generate CRDs for multiple API versions. It also ensures we can move to structural schemas without much fuss, as they have been marked stable in Kubernetes `1.17.x`. The only exception to this is the `.spec.values` field, that can contain any structure, but this is contained by marking the `HelmValues` field in the spec as `+kubebuilder:pruning:PreserveUnknownFields`. * We can manage all our published CRDs from a single definition, this is a huge win as this means we no longer have to make duplicate changes to both the `deploy/` folder _and_ the chart. * This clears the path for auto generating our CRD documentation, https://github.com/ahmetb/gen-crd-api-reference-docs may be interesting option to create this functionality, as it supports Markdown rendering. * It should make the planned 'Helm chart repository management using CRDs' feature easier to fabricate.
hiddeco
force-pushed
the
enhancement/crd-generation
branch
from
f9310c1 to
634b0c8
Compare
stefanprodan
reviewed
Mar 2, 2020
|
@stefanprodan going to merge this and do the renaming of the manifests and stuff in a separate PR, as due to the discussions this is going to be a bit more than just renaming the files. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.