Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

helm: load available getter plugins #263

Merged
merged 3 commits into from
Feb 5, 2020
Merged

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Jan 31, 2020

Resolves #228.

@hiddeco hiddeco force-pushed the enhancement/getter-plugins branch 3 times, most recently from a2423aa to 5e0fcdb Compare January 31, 2020 13:55
@hiddeco hiddeco requested a review from stefanprodan January 31, 2020 13:56
@hiddeco hiddeco marked this pull request as ready for review January 31, 2020 13:56
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think we need to add this to docs and provide examples for S3 and GSC (add an init container option to the helm chart?)

@hiddeco
Copy link
Member Author

hiddeco commented Feb 5, 2020

@stefanprodan given this PR is already cluttered due to the refactor I felt was necessary to do, I will pick this up in separate PRs. See linked issues above.

This is sufficient to make it work but the management of the
Helm environment is in need of some polishing. One of the issues
for Helm v2 is that the `$HELM_HOME/plugins` directory _must_
exist, or otherwise the client will bail.
@hiddeco hiddeco force-pushed the enhancement/getter-plugins branch from 5e0fcdb to 183f8bc Compare February 5, 2020 15:58
@hiddeco hiddeco merged commit 4365ce2 into master Feb 5, 2020
@hiddeco hiddeco deleted the enhancement/getter-plugins branch February 5, 2020 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm: support (repository) getter plugins
2 participants