Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

apis: correct JSON namespace tag for key selectors #262

Merged
merged 3 commits into from
Jan 31, 2020
Merged

apis: correct JSON namespace tag for key selectors #262

merged 3 commits into from
Jan 31, 2020

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Jan 30, 2020

Fixes #261

@hiddeco hiddeco requested a review from stefanprodan January 30, 2020 22:18
@hiddeco hiddeco force-pushed the bug/key-selectors-ns branch from 21923e9 to fb097fb Compare January 30, 2020 22:33
stefanprodan
stefanprodan approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiddeco hiddeco merged commit 33ff65f into master Jan 31, 2020
@hiddeco hiddeco deleted the bug/key-selectors-ns branch January 31, 2020 11:45
@carlpett
Copy link
Contributor

carlpett commented Feb 3, 2020

🤦‍♂️ Sorry about that, copy/paste too many things... Could this warrant a release, or should we build internal images until rc9/1.0-final?

@hiddeco
Copy link
Member Author

hiddeco commented Feb 3, 2020

@carlpett no worries, I did not catch it either during reviews.

RC.9 will be out this week, until then there are pre-release images available at fluxcd/helm-operator-prerelease

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Secrets Not Found When Created In Another Namespace
3 participants
@hiddeco @carlpett @stefanprodan