Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor status API #75

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Refactor status API #75

merged 1 commit into from
Sep 14, 2020

Conversation

seaneagan
Copy link
Contributor

@seaneagan seaneagan commented Sep 10, 2020 •
edited
Loading 

Refactor status API

This removes:

- Installed, Upgraded, RolledBack, and Uninstalled status conditions
  since they did not represent current state, but rather actions
  taken, which are already recorded by events.
- status.observedStateReconciled since it solved the problem of
  remembering past release (install/upgrade/test) success, but not
  past release failures, after other subsequent failures such as
  dependency failures, k8s API failures, etc.

This adds:

- Remediated status condition which records whether the release is
  currently in a remediated state. It is used to prevent release retries
  after remediation failures. We were previously not doing this for
  rollback failures.
- Released status condition which records whether the current state
  has been successfully released (install/upgrade/test). This is used to
  remember the last release attempt status, regardless of any subsequent
  other failures such as dependency failures, k8s API failures, etc.

This renames:

- Tested > TestSuccess status condition, for forward compatibility
  with interval based helm tests.

xRef: fluxcd/flux2#179

@seaneagan seaneagan force-pushed the remove-action-conditions branch 2 times, most recently from c95eded to 8e99dcf Compare September 11, 2020 13:35
@seaneagan seaneagan force-pushed the remove-action-conditions branch 4 times, most recently from 4716961 to 2b59511 Compare September 11, 2020 19:22
@seaneagan seaneagan marked this pull request as ready for review September 11, 2020 19:39
hiddeco
hiddeco approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo, other than that LGTM 🥇

controllers/helmrelease_controller.go Outdated Show resolved Hide resolved
@seaneagan seaneagan force-pushed the remove-action-conditions branch from 2b59511 to 1f37723 Compare September 14, 2020 12:56
@seaneagan
Refactor status API
0fd937e 
This removes:

- Installed, Upgraded, RolledBack, and Uninstalled status conditions
  since they did not represent current state, but rather actions
  taken, which are already recorded by events.
- status.observedStateReconciled since it solved the problem of
  remembering past release (install/upgrade/test) success, but not
  past release failures, after other subsequent failures such as
  dependency failures, k8s API failures, etc.

This adds:

- Remediated status condition which records whether the release is
  currently in a remediated state. It is used to prevent release retries
  after remediation failures. We were previously not doing this for
  rollback failures.
- Released status condition which records whether the current state
  has been successfully released (install/upgrade/test). This is used to
  remember the last release attempt status, regardless of any subsequent
  other failures such as dependency failures, k8s API failures, etc.

This renames:

- Tested > TestsSuccess status condition, for forward compatibility
  with interval based helm tests.
@seaneagan seaneagan force-pushed the remove-action-conditions branch from 1f37723 to 0fd937e Compare September 14, 2020 13:12
@hiddeco hiddeco added area/ux In pursuit of a delightful user experience enhancement New feature or request labels Sep 14, 2020
@seaneagan seaneagan merged commit 8c3d748 into fluxcd:master Sep 14, 2020
@seaneagan seaneagan deleted the remove-action-conditions branch September 14, 2020 13:35
jtyr pushed a commit to jtyr/fluxcd-helm-controller that referenced this pull request Dec 14, 2023
@dweomer
Merge pull request fluxcd#75 from dweomer/klipper-helm-0-4-0
4210588 
bump klipper-helm image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/ux In pursuit of a delightful user experience enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaneagan @hiddeco