Set deletion propagation for helm uninstall #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoffimar
force-pushed
the
deletionPropagation
branch
2 times, most recently
from
d7c0350 to
af466e5
Compare
hiddeco
force-pushed
the
deletionPropagation
branch
from
3ac9be0 to
4d39735
Compare
hiddeco
added
enhancement
hiddeco
reviewed
Jun 26, 2023
hoffimar
force-pushed
the
deletionPropagation
branch
from
1f66cc2 to
4de98bc
Compare
|
I did not introduce a new type for the option like was done for CRDsPolicy, as I found other examples where it wasn't done and this string is just passed to helm. Not sure whether there is some guideline though. |
hiddeco
force-pushed
the
deletionPropagation
branch
from
4de98bc to
b8cf651
Compare
Signed-off-by: Martin Hoffmann <[email protected]> Signed-off-by: Martin Hoffmann <[email protected]>
Signed-off-by: Martin Hoffmann <[email protected]>
hiddeco
force-pushed
the
deletionPropagation
branch
from
b8cf651 to
d656cb3
Compare
hiddeco
added a commit
that referenced
this pull request
Jul 11, 2023
Manual backport of the work done in #698, to keep things aligned. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
added a commit
that referenced
this pull request
Jul 14, 2023
Manual backport of the work done in #698, to keep things aligned. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
added a commit
that referenced
this pull request
Oct 31, 2023
Manual backport of the work done in #698, to keep things aligned. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
added a commit
that referenced
this pull request
Nov 21, 2023
Manual backport of the work done in #698, to keep things aligned. Signed-off-by: Hidde Beydals <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In helm 3.12 a feature was added (commit) to support other deletion modes than background during a helm uninstall. This PR attempts to pass the new property DeletionPropagation on the HelmRelease to the runner.
I'm not so sure about the needed default handling for this optional field. To not disturb existing installations, I made sure a value is returned in case there is no default yet persisted on the HelmRelease.