Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More graceful failure recovery #61

Merged
merged 4 commits into from
Sep 1, 2020
Merged

More graceful failure recovery #61

merged 4 commits into from
Sep 1, 2020

Commits on Aug 31, 2020

  1. More graceful failure recovery 

    - Ensure upgrade actually occurs if known state was not reached
  for any reason (other than install failure).
- After transient failures not tied to new state application, ensure
  spurious upgrades do not occur and ready state is again reached,
  by remembering that the known state was already successfully applied.
- Reset failure counts after success so they're not stale.
- Only lookup post-deployment release revision on remediation,
  since otherwise we already have it.
- Push status update after finding new state so user can observe.
    @seaneagan
    seaneagan committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    be9e22f View commit details
    Browse the repository at this point in the history

  2. Rename knownStateApplied to observedStateReconciled 

    This is more consistent with the existing terminology used.
    @seaneagan
    seaneagan committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    fd7d232 View commit details
    Browse the repository at this point in the history

  3. Record last observed time in status 

    This adds a .status.lastObservedTime field which records when the
HelmRelease was last observed by the controller. This allows the user
to observe whether the spec.interval and reconcileAt annotations are
triggering reconciliation attempts as desired.
    @seaneagan
    seaneagan committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    55f6038 View commit details
    Browse the repository at this point in the history

  4. Update status iff new state or done reconciling 

    Also set status.lastObservedTime to the actual time of the status update.
    @seaneagan
    seaneagan committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    0d64e8d View commit details
    Browse the repository at this point in the history