fuzz: Fix upstream build and optimise execution #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest base image should contain Go 1.18, removing the need of updating that ourselves, apart from benefiting from latest changes upstream. Signed-off-by: Paulo Gomes <[email protected]>
added 2 commits
September 2, 2022 15:59
The upstream build is failing with: /usr/local/bin/compile_native_go_fuzzer: line 35: addimport: command not found The changes uses the upstream approach to install the missing commands. Note that one of the reasons of the unilateral failure upstream is due to the base image changed in: google/oss-fuzz@e71e320 Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
makkes
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream build is failing with:
/usr/local/bin/compile_native_go_fuzzer: line 35: addimport: command not found.The changes uses the upstream approach to install the missing commands.
Note that one of the reasons of the unilateral failure upstream is due to the base image changed in: google/oss-fuzz@e71e320
The change upstream only breaks Go native fuzzing, and will be reverted on a follow-up upstream PR.