Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeconfig: err on missing declared SecretRef.Key #472

Merged
merged 1 commit into from
Apr 30, 2022
Merged

kubeconfig: err on missing declared SecretRef.Key #472

merged 1 commit into from
Apr 30, 2022

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Apr 29, 2022

Follow up on #461 to align with changes suggested during review in fluxcd/kustomize-controller#615.

@hiddeco hiddeco added the enhancement New feature or request label Apr 29, 2022
@hiddeco hiddeco requested a review from stefanprodan April 29, 2022 20:32
stefanprodan
stefanprodan approved these changes Apr 30, 2022
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco

@stefanprodan stefanprodan merged commit 746ade0 into main Apr 30, 2022
@stefanprodan stefanprodan deleted the secret-ref-key-tweaks branch April 30, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiddeco @stefanprodan