Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record suspend metrics #234

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Record suspend metrics #234

merged 1 commit into from
Mar 17, 2021

Conversation

somtochiama
Copy link
Member

Part of flux#590

Signed-off-by: Somtochi Onyekwere [email protected]

Signed-off-by: Somtochi Onyekwere <[email protected]>
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @somtochiama 🌻

@hiddeco hiddeco added area/ux In pursuit of a delightful user experience enhancement New feature or request labels Mar 17, 2021
@hiddeco hiddeco merged commit 046346f into fluxcd:main Mar 17, 2021
@stefanprodan
Copy link
Member

@hiddeco please undo this merge, the metric is not wired correctly, see fluxcd/kustomize-controller#299

@stefanprodan
Copy link
Member

the controller will panic with this change

hiddeco added a commit that referenced this pull request Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux In pursuit of a delightful user experience enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants