add a release deployment event when reconciling a release #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Salt <[email protected]>
hiddeco
reviewed
Feb 15, 2021
Signed-off-by: Will Salt <[email protected]>
|
@hiddeco yep, can do! Is that ok? I thought i would stick to similar wording as the success event being |
|
@william-salt-cko I think that in e.g. notification messages it is helpful to be notified of the precise action, because seeing an installation while you were expecting an upgrade may help you detect an e.g. miss-configuration faster. |
hiddeco
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, you are not sure if the release has started and you have to wait for events showing its success or failure, or watch the status of k8s resources.
This adds an event notifying us that a release has started, we have found this to be especially useful for our slack messages in our deployment channels.