Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flux version to bootstrap commit messages #904

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Add flux version to bootstrap commit messages #904

merged 1 commit into from
Feb 12, 2021

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Feb 12, 2021 •
edited
Loading

This PR changes the commit messages of flux bootstrap to include the actual flux version even when using latest.

Example:

flux bootstrap github \
--owner=stefanprodan \
--repository=test \
--branch=main \
--path=./clusters/my-cluster \
--personal

Screenshot 2021-02-12 at 10 33 39

Ref: #723

@stefanprodan stefanprodan added area/UX area/bootstrap Bootstrap related issues and pull requests area/install Install and uninstall related issues and pull requests labels Feb 12, 2021
@stefanprodan stefanprodan requested a review from hiddeco February 12, 2021 08:48
hiddeco
hiddeco approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will be much appreciated by users as they can now distinguish commits, thank you @stefanprodan 🍻

@stefanprodan stefanprodan merged commit 5003cf6 into main Feb 12, 2021
@stefanprodan stefanprodan deleted the add-version-to-commits branch February 12, 2021 09:38
@kingdonb kingdonb mentioned this pull request Nov 17, 2021
Open
ybelleguic pushed a commit to ybelleguic/flux2 that referenced this pull request Jan 9, 2023
@stefanprodan
Merge pull request fluxcd#904 from fluxcd/add-ca-cert
9c6dc33 
Add custom CA certificates to system certificates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/bootstrap Bootstrap related issues and pull requests area/install Install and uninstall related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @hiddeco