Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make flux bootstrap and install comments consistent #2066

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Make flux bootstrap and install comments consistent #2066

merged 1 commit into from
Nov 9, 2021

Conversation

jack-evans
Copy link
Contributor

@jack-evans jack-evans commented Nov 8, 2021 •
edited by stefanprodan
Loading

Signed-off-by: Jack Evans [email protected]

Fix: #2056

Changes:

  • removed bootstrap from GenWarning constant as to make it more generic
  • remove custom addition of the prints in flux install --export
  • Created new function GetGenWarning that generates a consistent generation header warning for both bootstrap and install commands

First PR so please let me know if there is anything a miss 🙂

@hiddeco hiddeco added area/bootstrap Bootstrap related issues and pull requests area/install Install and uninstall related issues and pull requests area/UX labels Nov 8, 2021
@jack-evans
Copy link
Contributor Author

Will squash commits

@jack-evans jack-evans requested a review from hiddeco November 9, 2021 13:07
@stefanprodan stefanprodan changed the title make flux bootstrap and install generation more consistent Make flux bootstrap and install comments consistent Nov 9, 2021
hiddeco
hiddeco approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jack-evans, and ✋ on first PR! 🌻

@stefanprodan stefanprodan merged commit 50af0ba into fluxcd:main Nov 9, 2021
@jack-evans jack-evans deleted the consistent-comments branch November 9, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/bootstrap Bootstrap related issues and pull requests area/install Install and uninstall related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistency in manifests generated by install vs bootstrap commands
3 participants
@jack-evans @hiddeco @stefanprodan