This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Make sure multi-yamels are delimited #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We concatenate multiple manifest files into a YAML multidoc, so that we can `kubectl apply` it all at once. The string `"---\n"` was used to put a YAML document delimiter betwen each file's contents; however, if a file does not end in a newline, this doens't end up on its own line, and it interpreted as part of the preceeding document. -> use `"\n---\n"`, on the basis that blank lines (if the file _does_ have a trailing newline) are harmless. This commit also adds a bit more detail of what's being applied, to the log.
squaremo
force-pushed
the
issue/916-missing-sync
branch
from
0c090b2 to
7ab9cbd
Compare
tamarakaufler
approved these changes
Jan 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We concatenate multiple manifest files into a YAML multidoc, so that
we can
kubectl applyit all at once. The string"---\n"was usedto put a YAML document delimiter betwen each file's contents; however,
if a file does not end in a newline, this doens't end up on its own
line, and it interpreted as part of the preceeding document.
-> use
"\n---\n", on the basis that blank lines (if the file doeshave a trailing newline) are harmless.
This commit also adds a bit more detail of what's being applied, to
the log.
Fixes #916.