This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Denormalise image refs from registry cache #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fetching image metadata, we canonicalise the image name, so that we can fetch it using any of its possible names (e.g., alpine, library/alpine, index.docker.io/library/alpine). When fetching though, we must remember to reconstruct the image refs as though they used the original form of name. To guard against getting this wrong again, I've put the `ImageMap` (map of image name to image metadata, effectively) in a struct so it can't be indexed directly.
samb1729
approved these changes
Dec 21, 2017
This was referenced Dec 22, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fetching image metadata, we canonicalise the image name, so that
we can fetch it using any of its possible names (e.g., alpine,
library/alpine, index.docker.io/library/alpine).
When fetching though, we must remember to reconstruct the image refs
as though they used the original form of name.
To guard against getting this wrong again, I've put the
ImageMap(map of image name to image metadata, effectively) in astruct so it can't be indexed directly.