This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Use Kubernetes API batch/v1beta1 instead of batch/v2alpha1 #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all clusters support the API batch/v2lpha1 (to wit: our own clusters don't). Instead use v1beta1, which is counter-intuitively only available in newer revisions of k8s.io/client-go. They are apparently backwards-compatible: fluxctl will happily deal with resources marked with either v1beta1 or v2alpha1, despite it using the API only for the former. Updating the client-go revision required a lot of `dep`ing around.
squaremo
force-pushed
the
issue/868-use-batch-v1beta1
branch
from
f4f99f5 to
ce3b293
Compare
samb1729
approved these changes
Jan 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all clusters support the API batch/v2lpha1 (to wit: our own
clusters don't). Instead use v1beta1, which is counter-intuitively
only available in newer revisions of k8s.io/client-go. They are
apparently backwards-compatible: fluxctl will happily deal with
resources marked with either v1beta1 or v2alpha1, despite it using the
API only for the former.