Remove Stdout/err fields from Kubectl struct

These values are never actually used. They look like they are, but their only
usage is immediately reassigned.

cluster/kubernetes/release.go

@@ -3,7 +3,6 @@ package kubernetes
 import (
 	"bytes"
 	"fmt"
-	"io"
 	"os/exec"
 	"strings"
 	"time"
@@ -13,14 +12,13 @@ import (
 	rest "k8s.io/client-go/rest"
 )
 
-func NewKubectl(exe string, config *rest.Config, stdout, stderr io.Writer) *Kubectl {
-	return &Kubectl{exe, config, stdout, stderr}
+func NewKubectl(exe string, config *rest.Config) *Kubectl {
+	return &Kubectl{exe, config}
 }
 
 type Kubectl struct {
-	exe            string
-	config         *rest.Config
-	stdout, stderr io.Writer
+	exe    string
+	config *rest.Config
 }
 
 func (c *Kubectl) connectArgs() []string {
@@ -50,10 +48,7 @@ func (c *Kubectl) connectArgs() []string {
 }
 
 func (c *Kubectl) kubectlCommand(args ...string) *exec.Cmd {
-	cmd := exec.Command(c.exe, append(c.connectArgs(), args...)...)
-	cmd.Stdout = c.stdout
-	cmd.Stderr = c.stderr
-	return cmd
+	return exec.Command(c.exe, append(c.connectArgs(), args...)...)
 }
 
 func (c *Kubectl) doCommand(logger log.Logger, newDefinition []byte, args ...string) error {

cmd/fluxd/main.go

@@ -209,7 +209,7 @@ func main() {
 		}
 		logger.Log("kubectl", kubectl)
 
-		kubectlApplier := kubernetes.NewKubectl(kubectl, restClientConfig, os.Stdout, os.Stderr)
+		kubectlApplier := kubernetes.NewKubectl(kubectl, restClientConfig)
 		k8s_inst, err := kubernetes.NewCluster(clientset, kubectlApplier, sshKeyRing, logger)
 		if err != nil {
 			logger.Log("err", err)