This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Supply a reason for "available images" being blank #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anything else worth waiting for? |
When flux has not managed to fetch the image metadata, it will supply a null in the "available images" field. But usually, we can figure out why there's no result -- it could be because we didn't have credentials for the registry, or perhaps because we just haven't tried to fetch them yet. This commit effectively adds a field to the API return value to hold that reason, and gives a placeholder reason in the case that available images weren't found. More work is needed to plumb through the _actual_ reasons from the registry.
Nope; but, after this is merged, we can try to plumb through some more informative errors. |
samb1729
approved these changes
Jan 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When flux has not managed to fetch the image metadata, it will supply
a null in the "available images" field. But usually, we can figure out
why there's no result -- it could be because we didn't have
credentials for the registry, or perhaps because we just haven't tried
to fetch them yet.
This commit effectively adds a field to the API return value to hold
that reason, and gives a placeholder reason in the case that available
images weren't found.
More work is needed to plumb through the actual reasons from the
registry. But it's probably worth waiting for #851 to be merged before
doing that.