This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Image metadata lookup and automation for push hooks #835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warming loop.
This commit introduces a priority channel, as a field of the warmer,
and changes the loop such that it looks up image data from the
priority channel in preference to refreshing image data from the
cluster.
It is possible to be notified about an image for which the loop does
not have credentials. This means the priority lookup will be skipped,
and is otherwise harmless. The credentials are only requested at the
start, and when the regular refresh is run. A refinement which
improves on this would be to plumb through a means of getting a
specific image's credentials from the cluster.
This is done as a callback, and the daemon method (newly exported)
AskForImagePoll
supplied. This is the simplest way, given that we want to keep the image polling (and other things) running on a ticker as well.The code that attempts to figure out if there's a new image comes with a couple of caveats:
AskForImagePoll
will discard duplicate requests.