-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
@stefanprodan Please let me know if you would find anything problematic or if anything important is missing here! 🙏 |
I will have to follow up and investigate:
This failure seems to be consistent, and might have been caused through one of these upgrades. |
This will probably not work Update github.com/weaveworks/common digest to 00e2e23 Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
go mod download Signed-off-by: Kingdon Barrett <[email protected]>
Update module github.com/docker/distribution to v2.8.1 Update module github.com/gorilla/websocket to v1.5.0 Update golang.org/x/oauth2 digest to 6242fa9 Update module github.com/fluxcd/helm-operator to v1.4.2 Update module github.com/google/go-containerregistry to v0.8.0 Update module github.com/fluxcd/distribution to v2 Signed-off-by: Kingdon Barrett <[email protected]>
This reverts commit 17e9c53. go mod download, go mod tidy Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]> update sops checksum Signed-off-by: Kingdon Barrett <[email protected]>
87e27a9
to
83132d3
Compare
This partially reverts commit 8ea1545. Signed-off-by: Kingdon Barrett <[email protected]>
In: 83132d3 I reverted the upgrade to I've rebased and signed off in ef1cfe7, going to run the tests again (and hopefully we see that e2e 13,14 are consistently passing now, instead of consistently failing.) |
83132d3
to
ef1cfe7
Compare
This looks to be passing, (now really ready for review.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @kingdonb
Fix #3587
Only the upgrades which did not seem to break anything, when I was testing at
kingdonb/flux
– I accepted basically every suggestion from Renovate bot, except for client-go which is blocked from upgrading until there are no supported K8s releases that remain in service, that can still work on non-v1 CRD. Flux must support those v1.21 and earlier as long as they are in use to remain backwards compatible.NB: it is still possible that I have broken something, it is difficult to tell flaky tests from actual failing tests. I will follow up on any failing tests, but I also need help from users to know if there are failures that weren't covered by any tests. (I'm sure you'll tell me!)
I am working on a local test scaffold so that I can see whether the tests pass or fail when ran against a local instance, although I have learned it's possible to get an SSH session to test failures when they happen at CircleCI, I am not sure if that will help, if the issue is transient or not, I should be able to reproduce it locally just as well.