Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add envsubst package to docker image #3407

Merged
merged 14 commits into from
Mar 16, 2021
Merged

Add envsubst package to docker image #3407

merged 14 commits into from
Mar 16, 2021

Conversation

stevehipwell
Copy link
Contributor

This PR adds the envsubst command to the Docker image to enable automation users to work around the limitations (by design) of kustomize.

This resolves #3138.

@stevehipwell
Copy link
Contributor Author

@kingdonb this replaces PR #3216 as I'd removed my original fork.

@stefanprodan
Copy link
Member

@stevehipwell can you please comment on this RFC for Flux2, looking forward to your opinion fluxcd/kustomize-controller#253

@stevehipwell
Copy link
Contributor Author

@stefanprodan what is the status of this PR?

Kingdon Barrett and others added 14 commits February 26, 2021 07:22
go.mod - reset k8s machinery to 1.17.17

This is the latest release that we can update to
-- see #3378

Try to remove when distribution/distribution#2905 is out

docker/distribution patch still needed for now

(Put it back for now.) On 2021-02-25 this has been merged, 2.7.2 of
docker/distribution should include it hopefully relatively soon!

Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Herman Banken <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Alaa Qutaish <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Alex Shpak <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Alex Shpak <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
@kingdonb
Copy link
Member

Rebasing for inclusion in the merge thru #3442 👍

@kingdonb kingdonb self-requested a review March 11, 2021 07:15
Copy link
Member

@kingdonb kingdonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kingdonb kingdonb merged commit d6aeb97 into fluxcd:master Mar 16, 2021
@stevehipwell
Copy link
Contributor Author

Thanks @kingdonb. Any idea when the chart for the v1.22.0 release will be created?

@yebyen
Copy link
Contributor

yebyen commented Mar 17, 2021

Pr #3449 is just approved and will be merged and pushed within about 30 minutes from now.

@stevehipwell stevehipwell deleted the envsubst branch March 17, 2021 18:05
@kingdonb
Copy link
Member

Release "flux" has been upgraded. Happy Helming!
NAME: flux
LAST DEPLOYED: Wed Mar 17 14:53:47 2021
NAMESPACE: flux
STATUS: deployed
REVISION: 7
...
flux-864d84f776-rpk7f            1/1     Running             0          18s

🎉

Thanks for your help with this release @stevehipwell

@kingdonb kingdonb removed their assignment Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add envsubst package to docker image
7 participants